This repository was archived by the owner on May 20, 2026. It is now read-only.
Security: Unvalidated URI schemes passed to VS Code opener - #5054
Open
tuanaiseo wants to merge 1 commit into
Open
Security: Unvalidated URI schemes passed to VS Code opener#5054tuanaiseo wants to merge 1 commit into
tuanaiseo wants to merge 1 commit into
Conversation
…ener The `open` method accepts an arbitrary string and directly passes `vscode.Uri.parse(target)` into `vscode.open` without validating scheme or destination. If `target` can be influenced by untrusted input (e.g., chat/tool output), this may allow opening dangerous URI schemes (including command-like or external handlers), enabling phishing flows or unintended command execution paths in the host environment. Affected files: opener.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Member
|
Thanks for the contribution! This repository has been archived because the project has moved into the main VS Code repository. Could you please reopen/recreate this PR against: We’ll continue reviewing contributions there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
openmethod accepts an arbitrary string and directly passesvscode.Uri.parse(target)intovscode.openwithout validating scheme or destination. Iftargetcan be influenced by untrusted input (e.g., chat/tool output), this may allow opening dangerous URI schemes (including command-like or external handlers), enabling phishing flows or unintended command execution paths in the host environment.Severity:
mediumFile:
src/platform/open/vscode/opener.tsSolution
Enforce an allowlist of safe schemes (for example
httpsand optionallyhttp), reject or sanitize all others, and consider explicit user confirmation for external links. Also validate hostnames when opening security-sensitive URLs.Changes
src/platform/open/vscode/opener.ts(modified)Testing