Skip to content

Stop bypassing the knowpro.interfaces aggregator #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bernhard Merkle (bmerkle) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop bypassing the knowpro.interfaces aggregator #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/typeagent/knowpro/add_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@
from . import knowledge_schema as kplib
from ..aitools.embeddings import IEmbeddingModel, NormalizedEmbedding
from ..storage.memory.semrefindex import collect_action_terms, collect_entity_terms
from .interfaces import AddMessagesResult
from .interfaces_core import IKnowledgeExtractor, IMessage, MessageOrdinal, TextLocation
from .interfaces import (
AddMessagesResult,
IKnowledgeExtractor,
IMessage,
MessageOrdinal,
TextLocation,
)

__all__ = ["add_messages_streaming"]

Expand Down
2 changes: 1 addition & 1 deletion src/typeagent/knowpro/conversation_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
IStorageProvider,
ITermToSemanticRefIndex,
MessageOrdinal,
TextLocation,
Topic,
)
from .interfaces_core import TextLocation
from .messageutils import get_all_message_chunk_locations

TMessage = TypeVar("TMessage", bound=IMessage)
Expand Down
3 changes: 1 addition & 2 deletions src/typeagent/podcasts/podcast_ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
import time

from ..knowpro.convsettings import ConversationSettings
from ..knowpro.interfaces import Datetime
from ..knowpro.interfaces_core import AddMessagesResult
from ..knowpro.interfaces import AddMessagesResult, Datetime
from ..knowpro.universal_message import format_timestamp_utc, UNIX_EPOCH
from ..storage.utils import create_storage_provider
from .podcast import Podcast, PodcastMessage, PodcastMessageMeta
Expand Down
3 changes: 1 addition & 2 deletions src/typeagent/storage/sqlite/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
from ...aitools.vectorbase import TextEmbeddingIndexSettings
from ...knowpro import interfaces
from ...knowpro.convsettings import MessageTextIndexSettings, RelatedTermIndexSettings
from ...knowpro.interfaces import ConversationMetadata, STATUS_INGESTED
from ...knowpro.interfaces_storage import ChunkFailure
from ...knowpro.interfaces import ChunkFailure, ConversationMetadata, STATUS_INGESTED
from ..memory.convthreads import ConversationThreads
from .collections import SqliteMessageCollection, SqliteSemanticRefCollection
from .messageindex import SqliteMessageTextIndex
Expand Down
Loading