Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ AGENTS.md. In all cases show what you added to AGENTS.md.
- Avoid potential import cycles between conversation orchestration and pipeline modules by using neutral payload protocols/arguments instead of importing concrete pipeline result classes across modules.
- Prefer ordinal type aliases (e.g., `MessageOrdinal`, `ChunkOrdinal`) over raw `int` in pipeline code for readability.
- When the user asks to "fix the test only", update tests/mocks first and avoid adding production compatibility fallbacks unless explicitly requested.
- For date/time range handling, use the half-open interval convention `[start, stop)` (stop is exclusive), as agreed in PR #198 — this avoids the ambiguity of an inclusive end (e.g. does "end of day" mean 00:00:00 or 23:59:59.999999?). Prefer this over inclusive-end ranges even when padding the end to end-of-day would also work.

## Package Management with uv

Expand Down Expand Up @@ -110,6 +111,15 @@ please follow these guidelines:
- **Exception**: Explicit re-export patterns like `from ... import X as X` or marked with "# For export"
- This prevents circular imports and makes dependencies clear

## Python Import Style Guidelines

* **Default to Module-Qualified Imports:** Prefer importing whole modules and using qualified calls (e.g., `import math; math.sqrt(16)` or `import pandas as pd; pd.DataFrame()`) to prevent namespace pollution, avoid name clashes, and provide immediate context for where functions or objects originate.
* **Use Direct Symbol Imports Cautiously:** Restrict direct imports (`from module import symbol`) to specific scenarios where they genuinely improve readability or adhere to standard conventions:
* Importing classes, exceptions, or constants (e.g., `from my_project.models import User`).
* Avoiding severe, repetitive visual clutter in heavy mathematical or algorithmic code.
* Standard library patterns (e.g., `from collections import defaultdict, Counter`).
* **Prohibit Wildcard Imports:** Never use wildcard imports (`from module import *`) under any circumstances.

* Order imports alphabetically after lowercasing; group them as follows
(with a blank line between groups):
1. standard library imports
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["uv_build>=0.9.10,<0.11.0"]
requires = ["uv_build>=0.9.10,<0.12.0"]
build-backend = "uv_build"

[project]
Expand Down Expand Up @@ -96,7 +96,7 @@ dev = [
"logfire>=4.32.1", # So 'make check' passes
"msgraph-sdk>=1.56.0",
"opentelemetry-instrumentation-httpx>=0.61b0",
"pyright>=1.1.409",
"pyright>=1.1.411",
"pytest>=9.0.3",
"pytest-asyncio>=1.3.0",
"pytest-mock>=3.15.1",
Expand Down
2 changes: 1 addition & 1 deletion src/typeagent/knowpro/answers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Licensed under the MIT License.

import asyncio
import os
from collections.abc import Iterable
from dataclasses import dataclass, field
import os
from typing import Any
Comment on lines 4 to 8

import typechat
Expand Down
8 changes: 4 additions & 4 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading