Repository navigation
Tie mixed-source behavior to Enhanced Citations and describe its settings - #1670
Merged
Paul Lizer (paullizer) merged 2 commits intoOct 6, 2026
Conversation
…n settings The V2 admin page filed five mixed-source switches under Knowledge > Deep Research with only their key names as labels. Two did nothing, and the behaviors that mattered had no control at all. Mixed-source Chat and Search, follow-up continuity, and cross-format Compare now follow Enhanced Citations on every settings load and save, with a read-time SIMPLECHAT_DISABLE_MIXED_SOURCE kill switch. Relevance candidates become a described switch under Enhanced Citations (default on, one-time upgrade), and the development metrics switch moves to Application Insights. The obsolete Analyze and shadow manifest switches are retired and their code removed, Analyze All stays off and hidden, and the cross-format Compare limitation now names Enhanced Citations. Version 0.261.260. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Paul Lizer (paullizer)
merged commit Oct 6, 2026
9a0c99f
into
paullizer-react-v2-ui
11 checks passed
14 of 24 tasks
Paul Lizer (paullizer)
added a commit
that referenced
this pull request
Oct 6, 2026
, #1671, #1674) and renumber the Operations settings parity to 0.261.269 Conflict resolutions: - admin_settings_fields.py: keep the full Operations block. The Application Insights and Health Check declarations #1670 added beside Appearance are superseded by it, and its mixed-source telemetry switch moves into the Operations Application Insights section, after the global logging readouts. Keep #1668's on_enable documentation and both sides' V2_ONLY_FIELDS entries. - route_backend_v2.py: fold content_understanding_supported into _build_runtime_flags. - SettingsSection.tsx, AdminSettingsPage.tsx, adminFields.ts: keep both the section guide and runtimeFlags props, and on_enable beside the Operations field properties. - operations.md, release_notes.md and tests: keep both sides. Both enable_dai_debug and enable_mixed_source_development_telemetry are documented rather than exempted, and Workspaces and Operations are both fully described. - Renumber this branch's 0.261.260 references to 0.261.269; the base's own 0.261.260 Web Search fix references are unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
15 of 24 tasks
Paul Lizer (paullizer)
added a commit
that referenced
this pull request
Oct 7, 2026
… and actions editors to 0.261.268 The base already uses 0.261.260 through 0.261.267, so this change moves to 0.261.268: config.py, the release notes section, and every version this branch added to its docs and test headers. The generated docs inventory is rebuilt from the merged source, and the category rail keeps both the base's collapsed-rail tooltip and this branch's scroll reset. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
V2 Admin Settings showed five undescribed "Mixed source ..." switches under Knowledge > Web & Research > Deep Research. Nothing declared them, so the
enable_*fallback scan filed them there because they share the word "source". Two of them did nothing. The switches that actually gate mixed document and spreadsheet behavior had no control anywhere and defaulted off, so for example comparing a PDF with an XLSX failed with "temporarily unavailable while cross-format Compare is disabled".enable_enhanced_citationson every settings load and save, because the spreadsheet engine they need only exists while Enhanced Citations is on. They stay hidden in V2.SIMPLECHAT_DISABLE_MIXED_SOURCE=trueis an emergency kill switch, applied when settings are read and never saved.enable_mixed_source_relevance_candidates, default on) is under Chat > Citations > Enhanced.enable_mixed_source_development_telemetry, default off) is under Operations > Logging & Health > Application Insights.mixed_source_settings_version, turns relevance candidates on once. An administrator's later "off" is kept.enable_mixed_source_analyzehas had no effect since 0.250.071.enable_mixed_source_manifestresolved shadow manifests and then discarded them.RETIRED_SETTING_KEYS, and the shadow-manifest code is deleted.enable_mixed_source_analyze_allstays off and hidden, because no chat or workflow screen can request it.After: Operations > Logging & Health > Application Insights
Notes for reviewers
recovery_changed, the same as after any admin save.enable_appinsights_global_loggingis now declared inapplication-insights-sectiontoo. The fallback scan had filed it under Debug Logging.paullizer-react-v2-uiat e66f8f4 (Fix V2 admin Web Search test failing for saved Foundry connections #1662, Hide always-on tabular preflight switches from V2 Admin Settings #1663, V2 media galleries, a media viewer and a richer drawer Media section (0.261.262) #1664, Explain the search result cache under Azure AI Search in V2 admin #1665, Fix Video Indexer deployer region, app permissions, and settings erasure #1667, V2 admin: Enhanced Extraction section with Content Understanding nested #1668) and renumbers the version to 0.261.266. The conflicts were additive: the fixes index, the V2 suppressed-keys table, and the placement test's lists.Linked issue
N/A (no tracking issue). Related initiative: Refs #1055
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-only (0.261.266)deployers/version.txtbumped, or not needed becausedeployers/was not changedTesting / validation
All run on the merged branch head, locally on Windows with Python 3.12 and Chromium via Playwright.
python functional_tests/test_mixed_source_settings_derivation.py(new): passed, 9/9python functional_tests/test_v2_admin_capability_placement.py: passed, 9/9python -m pyteston the 11ui_testsfiles that useAdminSettingsFixture, including the newui_tests/test_v2_admin_mixed_source_settings.py: 94 passedpython functional_tests/test_docs_app_surface_coverage.py: passed, 7/7python functional_tests/test_docs_site_quality.py: passed, 6/6python scripts/build_docs_inventory.py --check: passed, inventory in syncpython functional_tests/route_tests/test_route_blueprint_policy_inventory.py: passed, 12/12python functional_tests/route_tests/test_route_unauthenticated_policy_contract.py: passed, 7/7python functional_tests/route_tests/test_route_policy_test_coverage.py: passed, 2/2python scripts/check_xss_sinks.py --base-sha origin/paullizer-react-v2-ui --head-sha HEADon the changedapplication/files: passed (9 files)python scripts/check_broken_access_control.py --base-sha origin/paullizer-react-v2-ui --head-sha HEADon the changed Python files: passed (6 files)python -m pytest <file>on 20 related functional test files, covering mixed-source, the settings store and writers, the orchestration upgrade, and tabular.python -m pytestbatch of the 30functional_tests/test_v2_admin_*.pyfiles plustest_docs_link_integrity.py.paullizer-react-v2-ui(e66f8f4).content_screeningmodule, a pyOpenSSL/cryptography mismatch, and existing failures such as 11 broken relative links intest_docs_link_integrity.py.admin_settings_fields.pyswapped in, the built V2 page shows all five "Mixed source ..." rows under Deep Research (the Before screenshot). With this change, none appear.Documentation
Docs changed:
docs/explanation/fixes/MIXED_SOURCE_ADMIN_SETTINGS_FIX.mdMIXED_SOURCE_*feature docs,CROSS_FORMAT_COMPARE.md, andV2_ADMIN_CHAT_SETTINGS.mddocs/admin/chat.mdanddocs/admin/operations.mddocs/admin_configuration.md,docs/reference/application-workflows.md,docs/_data/features.yml, and the regenerateddocs/_data/app_surface.ymlSecurity checklist
@swagger_route(security=get_auth_security())(no new routes)sanitize_settings_for_user()(no change to what non-admin pages receive)