Skip to content

need a way to remove bindings! #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Thomas Ball (thomasjball) wants to merge 3 commits into from
Closed

need a way to remove bindings! #6657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
532c570
need a way to remove bindings!
thomasjball Nov 17, 2025
8239cc0
try this?
thomasjball Nov 17, 2025
6fa509b
one more time
thomasjball Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libs/core/codal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,13 @@ void registerWithDal(int id, int event, Action a, int flags) {
registerGCPtr(a);
}

void unregisterWithDal(int id, int event, Action a) {
uBit.messageBus.ignore(id, event, dispatchForeground, a);
decr(a);
unregisterGCPtr(a);
}


void fiberDone(void *a) {
decr((Action)a);
unregisterGCPtr((Action)a);
Expand Down
12 changes: 12 additions & 0 deletions libs/core/control.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

extern uint32_t __StackTop;

namespace pxt {
void unregisterWithDal(int id, int event, Action a);
}

/**
* How to create the event.
*/
Expand Down Expand Up @@ -312,6 +316,14 @@ namespace control {
registerWithDal(src, value, handler, (int)flags);
}

/**
* Removes an event handler binding.
*/
//%
void removeEventBinding(int src, int value, Action handler) {
unregisterWithDal(src, value, handler);
}

/**
* Gets the value of the last event executed on the bus
*/
Expand Down
Loading