chore(client): stub "crypto" for the browser build#41545
Merged
Conversation
Route Waiter through the shared createGuid() and satisfy its Node "crypto" import in the @playwright/client browser bundle with a minimal stub (randomBytes only, backed by WebCrypto). Removes the bespoke createGuidWithWebCrypto() helper that existed solely to dodge stubbing.
Contributor
Test results for "MCP"5 failed 7456 passed, 1132 skipped Merge workflow run. |
Skn0tt
approved these changes
Jun 30, 2026
Contributor
Test results for "tests 1"6 flaky49167 passed, 1163 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waiterthrough the sharedcreateGuid()and stub the Nodecryptomodule for the@playwright/clientbrowser bundle (minimalrandomBytes, backed by WebCrypto).createGuidWithWebCrypto()helper that only existed to avoid stubbingcrypto.