fix(mcp): close isolated contexts on client disposal#41540
Closed
oleksii-tumanov wants to merge 1 commit into
Closed
fix(mcp): close isolated contexts on client disposal#41540oleksii-tumanov wants to merge 1 commit into
oleksii-tumanov wants to merge 1 commit into
Conversation
Member
|
Somehow my agent did it with a smaller diff. Identical behavior though: https://github.com/microsoft/playwright/pull/41560/changes |
Contributor
Author
|
Thanks @pavelfeldman . The smaller production diff make sense. I analized both patches. I see that #41560 keeps the last-client browser shutdown path unchanged and reuses lifecycle log assertions additionally for concurrent HTTP and SSE. While old #41540 added a direct contexts().length check for direct validation. For future contributions, would you have preferred that I revise #41540 in that direction? I would have been happy to update it based on review feedback. Understanding that would help me better match the project’s preferred workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close the browser context owned by an isolated HTTP client when it disconnects.
Regression coverage for two concurrent isolated clients:
after one disconnects, the remaining client sees one live context instead of two.
Fixes #41539