Skip to content

chore(driver): roll to 1.64.1 #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 2 commits into from
Oct 20, 2026
Merged

chore(driver): roll to 1.64.1 #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7a858
chore(driver): roll to 1.64.1
yury-s Oct 20, 2026
a7d3b12
test: wait for frames before stopping Chromium tracing with screenshots
yury-s Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions playwright/src/test/java/com/microsoft/playwright/TestChromiumTracing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ void shouldCreateDirectoriesAsNeeded(@TempDir Path tempDir) {
}
}

private static void rafraf(Page page) {
int count = 2;
private static void rafraf(Page page, int count) {
for (int i = 0; i < count; i++) {
page.evaluate("() => new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)))");
}
Expand All @@ -71,7 +70,7 @@ void shouldRunWithCustomCategoriesIfProvided(@TempDir Path tempDir) throws IOExc
browser.startTracing(page, new Browser.StartTracingOptions()
.setPath(outputTraceFile)
.setCategories(asList("disabled-by-default-cc.debug")));
rafraf(page);
rafraf(page, 2);
browser.stopTracing();
try (FileReader fileReader = new FileReader(outputTraceFile.toFile())) {
JsonObject traceJson = new Gson().fromJson(fileReader, JsonObject.class);
Expand Down Expand Up @@ -134,6 +133,7 @@ void shouldSupportABufferWithoutAPath() {
try (Page page = browser.newPage()) {
browser.startTracing(page, new Browser.StartTracingOptions().setScreenshots(true));
page.navigate(server.PREFIX + "/grid.html");
rafraf(page, 100);
byte[] trace = browser.stopTracing();
assertTrue(new String(trace, StandardCharsets.UTF_8).contains("screenshot"));
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.64.0-beta-1791568591000
1.64.1
Loading