fix(webSocketRoute): handle close events without code/reason - #3345
Merged
Conversation
The closePage/closeServer events carry optional code and reason, but they were read with throwing accessors. When a page with a live routed WebSocket navigated or closed, the missing properties threw KeyNotFoundException inside Connection.Dispatch, closing the entire connection. Fixes: microsoft#3333
Simon Knott (Skn0tt)
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closePage/closeServerevents carry optionalcode/reasonin the protocol, but were read with throwing accessors — a routed WebSocket closed by navigation or page closure threwKeyNotFoundExceptioninsideConnection.Dispatchand killed the whole connection.TryGetPropertyand passnullthrough, matching the TypeScript client.should emit close upon frame navigationandshould not throw after page closuretests from upstream; both reproduced the crash before the fix.Fixes #3333