Skip to content

fix(transport): store expect errorDetails as serializable string #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitry Gozman (dgozman) merged 3 commits into from
Aug 12, 2026
Merged

fix(transport): store expect errorDetails as serializable string #3344

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90d10fc
fix(transport): store expect errorDetails as serializable string
kblok Aug 11, 2026
64d7c13
fix(transport): drop try/catch and unit test per review
kblok Aug 12, 2026
d167169
Apply suggestion from @kblok
kblok Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/Playwright/Core/Frame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,21 +1013,27 @@ await SendMessageToServerAsync(
Matches = options.IsNot,
Log = (e.Data[Connection.LogDataKey] as string[]) ?? Array.Empty<string>(),
};
if (e.Data[Connection.ErrorDetailsDataKey] is JsonElement details && details.ValueKind == JsonValueKind.Object)
// ErrorDetails is stored as raw JSON text for .NET Framework Exception.Data compatibility.
if (e.Data[Connection.ErrorDetailsDataKey] is string detailsJson && !string.IsNullOrEmpty(detailsJson))
{
if (details.TryGetProperty("customErrorMessage", out var customErrorMessage) && customErrorMessage.ValueKind == JsonValueKind.String)
using var detailsDocument = JsonDocument.Parse(detailsJson);
var details = detailsDocument.RootElement;
if (details.ValueKind == JsonValueKind.Object)
{
result.ErrorMessage = "Error: " + customErrorMessage.GetString();
}
if (details.TryGetProperty("received", out var received) && received.ValueKind == JsonValueKind.Object)
{
if (received.TryGetProperty("value", out var receivedValue))
if (details.TryGetProperty("customErrorMessage", out var customErrorMessage) && customErrorMessage.ValueKind == JsonValueKind.String)
{
result.Received = ScriptsHelper.ParseEvaluateResult<object>(receivedValue);
result.ErrorMessage = "Error: " + customErrorMessage.GetString();
}
if (received.TryGetProperty("ariaSnapshot", out var ariaSnapshot) && ariaSnapshot.ValueKind == JsonValueKind.String)
if (details.TryGetProperty("received", out var received) && received.ValueKind == JsonValueKind.Object)
{
result.ReceivedAriaSnapshot = ariaSnapshot.GetString();
if (received.TryGetProperty("value", out var receivedValue))
{
result.Received = ScriptsHelper.ParseEvaluateResult<object>(receivedValue);
}
if (received.TryGetProperty("ariaSnapshot", out var ariaSnapshot) && ariaSnapshot.ValueKind == JsonValueKind.String)
{
result.ReceivedAriaSnapshot = ariaSnapshot.GetString();
}
}
}
}
Expand Down
4 changes: 3 additions & 1 deletion src/Playwright/Transport/Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,9 @@ internal void Dispatch(PlaywrightServerMessage message)
if (message.Error != null && message.Result == null)
{
var exception = ParseException(message.Error.Error, FormatCallLog(message.Log));
exception.Data[ErrorDetailsDataKey] = message.ErrorDetails;
// Exception.Data values must be serializable on .NET Framework.
// Store ErrorDetails as raw JSON text (not JsonElement).
Comment thread
kblok marked this conversation as resolved.
Outdated
exception.Data[ErrorDetailsDataKey] = message.ErrorDetails?.GetRawText();
exception.Data[LogDataKey] = message.Log;
callback.TaskCompletionSource.TrySetException(exception);
}
Expand Down
Loading