Track CID path assignments by stable ID - #6303
Draft
Guillaume Hetier (guhetier) wants to merge 3 commits into
Draft
Track CID path assignments by stable ID#6303Guillaume Hetier (guhetier) wants to merge 3 commits into
Guillaume Hetier (guhetier) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Keep debug CID ownership tracking aligned with 32-bit path identifiers and reserve UINT32_MAX as the unassigned sentinel. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Record a destination CID's path ID once when assigned and retain it after detachment for debugging. Validate live detachment by checking path references instead of clearing the historical ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Guillaume Hetier (guhetier)
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## guhetier/defer_path_cid_replacement_copilot #6303 +/- ##
===============================================================================
+ Coverage 85.52% 85.55% +0.02%
===============================================================================
Files 60 60
Lines 19017 19014 -3
===============================================================================
+ Hits 16265 16267 +2
+ Misses 2752 2747 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace debug-only destination CID ownership pointers with stable path IDs. Record the path ID when a CID is first assigned and retain it after detachment so dumps preserve which path used the CID, while live validation continues to ensure retired CIDs are no longer referenced by any path.
Testing
Documentation
No documentation impact. This changes debug-only tracking and validation.