Defer destination CID replacement - #6298
Open
Guillaume Hetier (guhetier) wants to merge 10 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // | ||
| // Reprocess this index because removal shifted the remaining paths down. | ||
| // | ||
| --i; |
Collaborator
Author
There was a problem hiding this comment.
Intentional and needed for now, will be fixed with a refactor of QuicPathRemove later in the stack
Mark destination CIDs retired while processing frames, then replace them or remove unusable paths after receive batches no longer hold path pointers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Preserve silent abort handling after retiring an in-use CID and ensure a pending activation target replaces a retired CID before activation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Move pending-path CID provisioning into active-path update, keep the CID helper private, correct its annotation, and clarify removal-loop index handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Guillaume Hetier (guhetier)
force-pushed
the
guhetier/defer_path_cid_replacement_copilot
branch
from
September 3, 2026 23:42
40dcafa to
d296e37
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## guhetier/defer_active_path_copilot #6298 +/- ##
======================================================================
- Coverage 85.57% 85.52% -0.05%
======================================================================
Files 60 60
Lines 19033 19017 -16
======================================================================
- Hits 16287 16265 -22
- Misses 2746 2752 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Treat retiring a missing destination CID as a successful no-op. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Place QuicPathUpdateDestCid at its first declaration and remove the unnecessary scope in active path update. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Keep the retired destination CID associated with its path when no replacement is available, and validate the committed active path after path activation reorders the array. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
A path may retain a retired destination CID until deferred replacement. Skip the retirement bookkeeping when replacing one that is already retired. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Guard the retirement bookkeeping at its mutation boundary so replacing an already-retired CID cannot update connection CID counters twice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Guillaume Hetier (guhetier)
marked this pull request as ready for review
September 5, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defers destination CID replacement and path removal until receive processing no longer holds path pointers. Pending migration paths receive CID priority; migration is canceled when no CID is available, then remaining paths are updated or removed safely. Preserves silent abort behavior when an in-use CID was retired before frame processing fails.
Testing
Debug x64 Schannel build. Focused migration, rebinding, and path-validation tests (308 cases).
Documentation
No documentation impact.