Skip to content

Flush receive batch before path lookup - #6271

Open
Guillaume Hetier (guhetier) wants to merge 3 commits into
guhetier/refactor_network_pathfrom
guhetier/reafactor_network_path_2
Open

Flush receive batch before path lookup#6271
Guillaume Hetier (guhetier) wants to merge 3 commits into
guhetier/refactor_network_pathfrom
guhetier/reafactor_network_path_2

Conversation

@guhetier

@guhetier Guillaume Hetier (guhetier) commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Description

QuicConnGetPathForPacket mutate the Path array, potentially invalidating any pointer to a path.
This rearranges the receive batching loop to ensure a pointer to a path is never carried accros a call to QuicConnGetPathForPacket.

  • Flushes the current receive batch before looking up a packet from a different path.
  • Path matching is done without mutating the path array using QuicPathMatchPacket.

Testing

CI and local test run

Documentation

No documentation impact.

Avoid calling QuicConnGetPathForPacket while the receive batch still holds a pointer into the path array.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.34%. Comparing base (fb6595d) to head (7e5c632).

Files with missing lines Patch % Lines
src/core/connection.c 62.50% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           guhetier/refactor_network_path    #6271      +/-   ##
==================================================================
+ Coverage                           84.30%   85.34%   +1.03%     
==================================================================
  Files                                  60       60              
  Lines                               19005    19008       +3     
==================================================================
+ Hits                                16022    16222     +200     
+ Misses                               2983     2786     -197     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guhetier
Guillaume Hetier (guhetier) marked this pull request as ready for review August 27, 2026 22:14
@guhetier
Guillaume Hetier (guhetier) requested a review from a team as a code owner August 27, 2026 22:14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant