Flush receive batch before path lookup - #6271
Open
Guillaume Hetier (guhetier) wants to merge 3 commits into
Open
Flush receive batch before path lookup#6271Guillaume Hetier (guhetier) wants to merge 3 commits into
Guillaume Hetier (guhetier) wants to merge 3 commits into
Conversation
Avoid calling QuicConnGetPathForPacket while the receive batch still holds a pointer into the path array. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## guhetier/refactor_network_path #6271 +/- ##
==================================================================
+ Coverage 84.30% 85.34% +1.03%
==================================================================
Files 60 60
Lines 19005 19008 +3
==================================================================
+ Hits 16022 16222 +200
+ Misses 2983 2786 -197 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Guillaume Hetier (guhetier)
marked this pull request as ready for review
August 27, 2026 22:14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QuicConnGetPathForPacketmutate thePatharray, potentially invalidating any pointer to a path.This rearranges the receive batching loop to ensure a pointer to a path is never carried accros a call to
QuicConnGetPathForPacket.QuicPathMatchPacket.Testing
CI and local test run
Documentation
No documentation impact.