Skip to content

Encapsulate connection paths in QUIC_PATH_SET - #6270

Open
Guillaume Hetier (guhetier) wants to merge 8 commits into
mainfrom
guhetier/refactor_network_path
Open

Encapsulate connection paths in QUIC_PATH_SET#6270
Guillaume Hetier (guhetier) wants to merge 8 commits into
mainfrom
guhetier/refactor_network_path

Conversation

@guhetier

@guhetier Guillaume Hetier (guhetier) commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Encapsulates the connection path array and its bookkeeping in QUIC_PATH_SET.
There is no behavior change, this is preparatory work for further refactoring.

  • Adds path-set initialization and active-path access helpers.
  • Moves NextPathId into the path set.
  • Initializes the path set before congestion control and updates congestion-control tests.
    • Congestion control was accessing path[0] before it was initialized
  • Replaces direct active-path array access with the path-set helper.

Testing

CI

Documentation

No documentation impact.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Track the deferred work outside the source tree so it can be addressed in later stack layers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Ensure the active path exists before congestion control initialization accesses it through the path set abstraction.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 03ce1c1f-9bb3-4a56-be65-d7f4d3fb46eb
@guhetier
Guillaume Hetier (guhetier) marked this pull request as ready for review August 27, 2026 18:45
@guhetier
Guillaume Hetier (guhetier) requested a review from a team as a code owner August 27, 2026 18:45
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.48276% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.30%. Comparing base (dde597c) to head (fb6595d).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/core/connection.c 87.30% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6270      +/-   ##
==========================================
- Coverage   86.03%   84.30%   -1.73%     
==========================================
  Files          60       60              
  Lines       18973    19005      +32     
==========================================
- Hits        16323    16022     -301     
- Misses       2650     2983     +333     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant