[CP] Fix leak on ACK encryption-level mismatch in loss detection (#6232) - #6268
Merged
Gaurav Singh (gaurav2699) merged 1 commit intoAug 26, 2026
Merged
Conversation
`QuicLossDetectionProcessAckBlocks` moves acknowledged packets out of the `SentPackets`/`LostPackets` lists into a local `AckedPackets` list *before* validating that each packet's encryption level matches the ACK frame's level. On a mismatch it returned early without returning the already-unlinked packets to the pool, leaking their metadata and the resources held by their frames. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/62826410 NA NA --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f374866-40d2-4c87-bd7d-2f5199ac33b3
Guillaume Hetier (guhetier)
approved these changes
Aug 26, 2026
Gaurav Singh (gaurav2699)
added a commit
that referenced
this pull request
Aug 26, 2026
…) (#6269) ## Description `QuicLossDetectionProcessAckBlocks` moves acknowledged packets out of the `SentPackets`/`LostPackets` lists into a local `AckedPackets` list *before* validating that each packet's encryption level matches the ACK frame's level. On a mismatch it returned early without returning the already-unlinked packets to the pool, leaking their metadata and the resources held by their frames. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/62826410 ## Testing NA ## Documentation NA <!-- Companion PR for release/2.5: #6268 --> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f374866-40d2-4c87-bd7d-2f5199ac33b3
Gaurav Singh (gaurav2699)
deleted the
gaurasingh/cp_ack_level_leak_2_5_copilot
branch
August 26, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QuicLossDetectionProcessAckBlocksmoves acknowledged packets out of theSentPackets/LostPacketslists into a localAckedPacketslist beforevalidating that each packet's encryption level matches the ACK frame's level.
On a mismatch it returned early without returning the already-unlinked packets
to the pool, leaking their metadata and the resources held by their frames.
Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/62826410
Testing
NA
Documentation
NA