Skip to content

[Squad] Randomize previously-disabled SpinQuic settings to improve coverage #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gaurav Singh (gaurav2699) wants to merge 7 commits into
base: main
Choose a base branch
from
+112 −71
Open

[Squad] Randomize previously-disabled SpinQuic settings to improve coverage #6204

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b170b1
Randomize previously-disabled SpinQuic settings to improve coverage
gaurav2699 Aug 7, 2026
0a53567
test
gaurav2699 Aug 10, 2026
f23fa34
Trim verbose comment in SpinQuicRandomizeSettings case 35
gaurav2699 Aug 11, 2026
9dcce04
Merge branch 'main' of https://github.com/microsoft/msquic into user/…
gaurav2699 Aug 12, 2026
b5dc214
removed MaxAckDelay stop loss
gaurav2699 Aug 12, 2026
21fbaf3
Add unbounded GetRandom<T>() so SpinQuic settings reach type maximums
gaurav2699 Aug 27, 2026
d988871
Rename bounded TryGetRandom to TryGetRandomBounded
gaurav2699 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 69 additions & 63 deletions src/tools/spin/spinquic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,159 +665,165 @@ struct SetParamHelper {

void SpinQuicRandomizeSettings(QUIC_SETTINGS& Settings, uint16_t ThreadID)
{
switch (GetRandom(38, ThreadID)) {
switch (GetRandom(39, ThreadID)) {
case 0:
//Settings.MaxBytesPerKey = GetRandom(UINT64_MAX);
//Settings.IsSet.MaxBytesPerKey = TRUE;
Settings.MaxBytesPerKey = GetRandom(UINT64_MAX, ThreadID);
Settings.IsSet.MaxBytesPerKey = TRUE;
break;
case 1:
//Settings.HandshakeIdleTimeoutMs = GetRandom(UINT64_MAX);
//Settings.IsSet.HandshakeIdleTimeoutMs = TRUE;
Settings.HandshakeIdleTimeoutMs = GetRandom(UINT64_MAX, ThreadID);
Settings.IsSet.HandshakeIdleTimeoutMs = TRUE;
break;
case 2:
//Settings.IdleTimeoutMs = GetRandom(UINT64_MAX);
//Settings.IsSet.IdleTimeoutMs = TRUE;
Settings.IdleTimeoutMs = GetRandom(UINT64_MAX, ThreadID);
Settings.IsSet.IdleTimeoutMs = TRUE;
break;
case 3:
//Settings.MtuDiscoverySearchCompleteTimeoutUs = GetRandom(UINT64_MAX);
//Settings.IsSet.MtuDiscoverySearchCompleteTimeoutUs = TRUE;
Settings.MtuDiscoverySearchCompleteTimeoutUs = GetRandom(UINT64_MAX, ThreadID);
Settings.IsSet.MtuDiscoverySearchCompleteTimeoutUs = TRUE;
break;
case 4:
//Settings.TlsClientMaxSendBuffer = GetRandom(UINT32_MAX);
//Settings.IsSet.TlsClientMaxSendBuffer = TRUE;
Settings.TlsClientMaxSendBuffer = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.TlsClientMaxSendBuffer = TRUE;
break;
case 5:
//Settings.TlsServerMaxSendBuffer = GetRandom(UINT32_MAX);
//Settings.IsSet.TlsServerMaxSendBuffer = TRUE;
Settings.TlsServerMaxSendBuffer = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.TlsServerMaxSendBuffer = TRUE;
break;
case 6:
//Settings.StreamRecvWindowDefault = GetRandom(UINT32_MAX);
//Settings.IsSet.StreamRecvWindowDefault = TRUE;
Settings.StreamRecvWindowDefault = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.StreamRecvWindowDefault = TRUE;
break;
case 7:
//Settings.StreamRecvBufferDefault = GetRandom(UINT32_MAX);
//Settings.IsSet.StreamRecvBufferDefault = TRUE;
Settings.StreamRecvBufferDefault = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.StreamRecvBufferDefault = TRUE;
break;
case 8:
//Settings.ConnFlowControlWindow = GetRandom(UINT32_MAX);
//Settings.IsSet.ConnFlowControlWindow = TRUE;
Settings.ConnFlowControlWindow = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.ConnFlowControlWindow = TRUE;
break;
case 9:
//Settings.MaxWorkerQueueDelayUs = GetRandom(UINT32_MAX);
//Settings.IsSet.MaxWorkerQueueDelayUs = TRUE;
Settings.MaxWorkerQueueDelayUs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.MaxWorkerQueueDelayUs = TRUE;
break;
case 10:
//Settings.MaxStatelessOperations = GetRandom(UINT32_MAX);
//Settings.IsSet.MaxStatelessOperations = TRUE;
Settings.MaxStatelessOperations = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.MaxStatelessOperations = TRUE;
break;
case 11:
//Settings.InitialWindowPackets = GetRandom(UINT32_MAX);
//Settings.IsSet.InitialWindowPackets = TRUE;
Settings.InitialWindowPackets = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.InitialWindowPackets = TRUE;
break;
case 12:
//Settings.SendIdleTimeoutMs = GetRandom(UINT32_MAX);
//Settings.IsSet.SendIdleTimeoutMs = TRUE;
Settings.SendIdleTimeoutMs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.SendIdleTimeoutMs = TRUE;
break;
case 13:
//Settings.InitialRttMs = GetRandom(UINT32_MAX);
//Settings.IsSet.InitialRttMs = TRUE;
Settings.InitialRttMs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.InitialRttMs = TRUE;
break;
case 14:
//Settings.MaxAckDelayMs = GetRandom(UINT32_MAX);
//Settings.IsSet.MaxAckDelayMs = TRUE;
Settings.MaxAckDelayMs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.MaxAckDelayMs = TRUE;
break;
case 15:
//Settings.DisconnectTimeoutMs = GetRandom(UINT32_MAX);
//Settings.IsSet.DisconnectTimeoutMs = TRUE;
Settings.DisconnectTimeoutMs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.DisconnectTimeoutMs = TRUE;
break;
case 16:
//Settings.KeepAliveIntervalMs = GetRandom(UINT32_MAX);
//Settings.IsSet.KeepAliveIntervalMs = TRUE;
Settings.KeepAliveIntervalMs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.KeepAliveIntervalMs = TRUE;
break;
case 17:
Settings.CongestionControlAlgorithm = GetRandom((uint16_t)QUIC_CONGESTION_CONTROL_ALGORITHM_MAX, ThreadID);
Settings.IsSet.CongestionControlAlgorithm = TRUE;
break;
case 18:
//Settings.PeerBidiStreamCount = GetRandom(UINT16_MAX);
//Settings.IsSet.PeerBidiStreamCount = TRUE;
Settings.PeerBidiStreamCount = GetRandom((uint16_t)UINT16_MAX, ThreadID);
Settings.IsSet.PeerBidiStreamCount = TRUE;
break;
case 19:
//Settings.PeerUnidiStreamCount = GetRandom(UINT16_MAX);
//Settings.IsSet.PeerUnidiStreamCount = TRUE;
Settings.PeerUnidiStreamCount = GetRandom((uint16_t)UINT16_MAX, ThreadID);
Settings.IsSet.PeerUnidiStreamCount = TRUE;
break;
case 20:
//Settings.MaxBindingStatelessOperations = GetRandom(UINT16_MAX);
//Settings.IsSet.MaxBindingStatelessOperations = TRUE;
Settings.MaxBindingStatelessOperations = GetRandom((uint16_t)UINT16_MAX, ThreadID);
Settings.IsSet.MaxBindingStatelessOperations = TRUE;
break;
case 21:
//Settings.StatelessOperationExpirationMs = GetRandom(UINT16_MAX);
//Settings.IsSet.StatelessOperationExpirationMs = TRUE;
Settings.StatelessOperationExpirationMs = GetRandom((uint16_t)UINT16_MAX, ThreadID);
Settings.IsSet.StatelessOperationExpirationMs = TRUE;
break;
case 22:
//Settings.MinimumMtu = GetRandom(UINT16_MAX);
//Settings.IsSet.MinimumMtu = TRUE;
Settings.MinimumMtu = GetRandom((uint16_t)UINT16_MAX, ThreadID);
Settings.IsSet.MinimumMtu = TRUE;
break;
case 23:
//Settings.MaximumMtu = GetRandom(UINT16_MAX);
//Settings.IsSet.MaximumMtu = TRUE;
Settings.MaximumMtu = GetRandom((uint16_t)UINT16_MAX, ThreadID);
Settings.IsSet.MaximumMtu = TRUE;
break;
case 24:
//Settings.SendBufferingEnabled = GetRandom((uint8_t)1);
//Settings.IsSet.SendBufferingEnabled = TRUE;
Settings.SendBufferingEnabled = GetRandom((uint8_t)2, ThreadID);
Comment thread
gaurav2699 marked this conversation as resolved.
Settings.IsSet.SendBufferingEnabled = TRUE;
break;
case 25:
Settings.PacingEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.PacingEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.PacingEnabled = TRUE;
break;
case 26:
Settings.MigrationEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.MigrationEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.MigrationEnabled = TRUE;
break;
case 27:
Settings.DatagramReceiveEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.DatagramReceiveEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.DatagramReceiveEnabled = TRUE;
break;
case 28:
Settings.ServerResumptionLevel = GetRandom((uint8_t)3, ThreadID);
Settings.IsSet.ServerResumptionLevel = TRUE;
break;
case 29:
Settings.GreaseQuicBitEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.GreaseQuicBitEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.GreaseQuicBitEnabled = TRUE;
break;
case 30:
Settings.EcnEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.EcnEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.EcnEnabled = TRUE;
break;
case 31:
//Settings.MaxOperationsPerDrain = GetRandom(UINT8_MAX);
//Settings.IsSet.MaxOperationsPerDrain = TRUE;
Settings.MaxOperationsPerDrain = GetRandom((uint8_t)UINT8_MAX, ThreadID);
Settings.IsSet.MaxOperationsPerDrain = TRUE;
break;
case 32:
//Settings.MtuDiscoveryMissingProbeCount = GetRandom(UINT8_MAX);
//Settings.IsSet.MtuDiscoveryMissingProbeCount = TRUE;
Settings.MtuDiscoveryMissingProbeCount = GetRandom((uint8_t)UINT8_MAX, ThreadID);
Settings.IsSet.MtuDiscoveryMissingProbeCount = TRUE;
break;
case 33:
//Settings.DestCidUpdateIdleTimeoutMs = GetRandom(UINT32_MAX);
//Settings.IsSet.DestCidUpdateIdleTimeoutMs = TRUE;
Settings.DestCidUpdateIdleTimeoutMs = GetRandom(UINT32_MAX, ThreadID);
Settings.IsSet.DestCidUpdateIdleTimeoutMs = TRUE;
break;
case 34:
Settings.HyStartEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.HyStartEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.HyStartEnabled = TRUE;
break;
case 35:
// Pinned to 0: enabling this post-start trips a FRE_ASSERT in
// QuicConnApplyNewSettings (spin false positive, not a product bug).
Settings.EncryptionOffloadAllowed = GetRandom((uint8_t)1, ThreadID);
Settings.IsSet.EncryptionOffloadAllowed = TRUE;
break;
case 36:
Settings.ReliableResetEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.ReliableResetEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.ReliableResetEnabled = TRUE;
break;
case 37:
Settings.OneWayDelayEnabled = GetRandom((uint8_t)1, ThreadID);
Settings.OneWayDelayEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.OneWayDelayEnabled = TRUE;
break;
case 38:
Settings.NetStatsEventEnabled = GetRandom((uint8_t)2, ThreadID);
Settings.IsSet.NetStatsEventEnabled = TRUE;
break;
default:
break;
}
Expand Down
Loading