Skip to content

Update Catch2 and simplify concurrent test assertions - #5558

Open
Nicolas Pedernera (Nicolas-Pedernera) wants to merge 2 commits into
microsoft:mainfrom
Nicolas-Pedernera:fix/catch2-multithreading
Open

Update Catch2 and simplify concurrent test assertions#5558
Nicolas Pedernera (Nicolas-Pedernera) wants to merge 2 commits into
microsoft:mainfrom
Nicolas-Pedernera:fix/catch2-multithreading

Conversation

@Nicolas-Pedernera

@Nicolas-Pedernera Nicolas Pedernera (Nicolas-Pedernera) commented Sep 8, 2026

Copy link
Copy Markdown

Summary

  • Update Catch2 to v3.9.0.
  • Enable Catch2 experimental thread-safe assertions.
  • Remove the failure_count workaround from the sock_addr concurrent tests.
  • Use CHECK for assertions performed by the worker threads.

Context

Catch2 now provides an opt-in configuration for thread-safe assertions. This allows the concurrent sock_addr tests to be simplified and removes the workaround introduced in #4155.

This addresses the cleanup requested in #4553.

Validation

  • git diff --check passes.
  • Catch2 v3.9.0 was configured successfully with CATCH_CONFIG_EXPERIMENTAL_THREAD_SAFE_ASSERTIONS=ON.
  • Full Windows test execution should be validated by CI.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request isn't linked to any GitHub issue. Please reference an issue with a keyword such as Fixes #123, Closes #456, etc., so the work can be tracked.

@Nicolas-Pedernera

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@Nicolas-Pedernera

Copy link
Copy Markdown
Author

@oga35767-eng

Copy link
Copy Markdown

Yy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants