Skip to content

Fix SA1214 and IDISP003 analyzer violations in SampleContainer #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weiyuanyue merged 2 commits into from
Jan 15, 2026
Merged

Fix SA1214 and IDISP003 analyzer violations in SampleContainer #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75e6b3
Initial plan
Copilot Jan 15, 2026
e981e68
Fix SA1214 and IDISP003 analyzer errors in SampleContainer
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions AIDevGallery/Controls/SampleContainer.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ public List<string> NugetPackageReferences
public static readonly DependencyProperty NugetPackageReferencesProperty =
DependencyProperty.Register("NugetPackageReferences", typeof(List<string>), typeof(SampleContainer), new PropertyMetadata(null));

private readonly object _ctsLock = new object();
private RichTextBlockFormatter codeFormatter;
private Dictionary<string, string> codeFiles = new();
private Sample? _sampleCache;
private Dictionary<ModelType, ExpandedModelDetails>? _cachedModels;
private List<ModelDetails>? _modelsCache;
private WinMlSampleOptions? _currentWinMlSampleOptions;
private CancellationTokenSource? _sampleLoadingCts;
private readonly object _ctsLock = new object();
private TaskCompletionSource? _sampleLoadedCompletionSource;
private double _codePaneWidth;
private ModelType? _wcrApi;
Expand Down Expand Up @@ -119,10 +119,14 @@ private void CancelCTS()

if (cts != null)
{
using (cts)
try
{
cts.Cancel();
}
finally
{
cts.Dispose();
}
}
}

Expand Down