Skip to content

CLI: Make container id required for stop command #41108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkbennett wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

CLI: Make container id required for stop command #41108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/windows/wslc/commands/ContainerStopCommand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace wsl::windows::wslc {
std::vector<Argument> ContainerStopCommand::GetArguments() const
{
return {
Argument::Create(ArgType::ContainerId, std::nullopt, NO_LIMIT),
Argument::Create(ArgType::ContainerId, true, NO_LIMIT),
Argument::Create(ArgType::Signal),
Argument::Create(ArgType::Time),
};
Expand Down
3 changes: 2 additions & 1 deletion test/windows/wslc/CommandLineTestCases.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ COMMAND_LINE_TEST_CASE(L"container run ubuntu", L"run", true)
COMMAND_LINE_TEST_CASE(L"container run --cidfile C:\\temp\\cidfile ubuntu", L"run", true)
COMMAND_LINE_TEST_CASE(L"container run -it --name foo ubuntu", L"run", true)
COMMAND_LINE_TEST_CASE(L"container run --rm -it --name foo ubuntu", L"run", true)
COMMAND_LINE_TEST_CASE(L"stop", L"stop", true)
COMMAND_LINE_TEST_CASE(L"stop", L"stop", false) // Missing required container-id positional
COMMAND_LINE_TEST_CASE(L"container stop", L"stop", false) // Missing required container-id positional
COMMAND_LINE_TEST_CASE(L"container stop cont1 --signal 9", L"stop", true)
COMMAND_LINE_TEST_CASE(L"container stop cont1 --signal SIGALRM", L"stop", true)
COMMAND_LINE_TEST_CASE(L"container stop cont1 --signal sigkill", L"stop", true)
Expand Down
Loading