Skip to content

Bump Linux SDK to 1.23.0 and guard char->wide formatters to Windows #41071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhillis merged 1 commit into from
Jul 22, 2026
+8 −1
Merged

Bump Linux SDK to 1.23.0 and guard char->wide formatters to Windows #41071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<package id="Microsoft.WSL.Dependencies.arm64fre" version="10.0.27820.1000-250318-1700.rs-base2-hyp" targetFramework="native" />
<package id="Microsoft.WSL.DeviceHost" version="1.2.48-0" />
<package id="Microsoft.WSL.Kernel" version="6.18.35.2-1" targetFramework="native" />
<package id="Microsoft.WSL.LinuxSdk" version="1.20.0" targetFramework="native" />
<package id="Microsoft.WSL.LinuxSdk" version="1.23.0" targetFramework="native" />
<package id="Microsoft.WSL.TestData" version="0.5.0" />
<package id="Microsoft.WSL.TestDistro" version="2.7.1-1" />
<package id="Microsoft.WSLg" version="1.0.79" />
Expand Down
7 changes: 7 additions & 0 deletions src/shared/inc/stringshared.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,11 @@ struct std::formatter<std::source_location, wchar_t>
}
};

// char -> wchar_t formatting is only used by the Windows components. libc++ (used to

@OneBlue OneBlue Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad to learn about this, but I guess this will be a problem for later

// build the Linux components) now provides these as deleted specializations per C++23
// [format.formatter.spec], which would collide, so restrict them to Windows.
#ifdef WIN32

template <>
struct std::formatter<char*, wchar_t>
{
Expand Down Expand Up @@ -995,6 +1000,8 @@ struct std::formatter<std::basic_string<char, Traits, Allocator>, wchar_t>
}
};

#endif // WIN32

template <>
struct std::formatter<std::filesystem::path, wchar_t>
{
Expand Down