Fix cgmanifest.json hash format and add type:git entries for NOTICE generation#41025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Component Governance manifest to unblock CG registration and improve NOTICE/license resolution for several third-party OSS components by using accepted hash formats and adding git coordinates.
Changes:
- Changed
type: "other"component hashes for boost, yaml-cpp, GSL, and nlohmann/json fromsha256:tosha1:format. - Added
type: "git"registrations (repositoryUrl + commitHash) for yaml-cpp, GSL, and nlohmann/json to support notice/license resolution pipelines.
beena352
marked this pull request as ready for review
July 8, 2026 18:33
OneBlue
approved these changes
Jul 8, 2026
OneBlue
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. One minor question
benhillis
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix Component Governance registration failures for 4 OSS components (nlohmann::json, GSL, yaml-cpp, boost) by converting their hash format from sha256 to sha1, and add type: "git" entries for yaml-cpp, GSL, and nlohmann::json so the notice pipeline can resolve their licenses.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The wsl-github-notice pipeline was silently rejecting 4 type: "other" cgmanifest entries during CG registration with:
The provided user input is not valid. Parameter name: 'Hash'.
Root cause: CG's server does not accept sha256: prefixed hashes for type: "other" registrations, only sha1: works (as evidenced by the libarchive entry which was already using sha1 and being accepted).
Changes:
Result: Registrations went from 35 accepted (4 rejected) → 44 accepted (0 rejected). GSL and nlohmann::json now appear in the generated NOTICE.txt. yaml-cpp and boost will appear once their ClearlyDefined harvests complete (~2 weeks, already triggered).
Validation Steps Performed
• microsoft/gsl a3534567... - MIT license present
• nlohmann/json 55f93686... - MIT license present