Skip to content

Fix cgmanifest.json hash format and add type:git entries for NOTICE generation#41025

Merged
beena352 merged 3 commits into
masterfrom
user/beenachauhan/fix-cgmanifest-hash
Jul 20, 2026
Merged

Fix cgmanifest.json hash format and add type:git entries for NOTICE generation#41025
beena352 merged 3 commits into
masterfrom
user/beenachauhan/fix-cgmanifest-hash

Conversation

@beena352

@beena352 beena352 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

Fix Component Governance registration failures for 4 OSS components (nlohmann::json, GSL, yaml-cpp, boost) by converting their hash format from sha256 to sha1, and add  type: "git"  entries for yaml-cpp, GSL, and nlohmann::json so the notice pipeline can resolve their licenses.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

The  wsl-github-notice  pipeline was silently rejecting 4  type: "other"  cgmanifest entries during CG registration with:
The provided user input is not valid. Parameter name: 'Hash'.
Root cause: CG's server does not accept sha256:  prefixed hashes for type: "other" registrations, only sha1:  works (as evidenced by the libarchive entry which was already using sha1 and being accepted).
Changes:

  1. Converted hash format from sha256:  to sha1:  for boost, yaml-cpp, GSL, and nlohmann::json, fixing the registration rejection.
  2. Added type: "git" entries (with repositoryUrl + commitHash) for yaml-cpp, GSL, and nlohmann::json, same dual-registration pattern libarchive and boost already use. This gives notice@0 a coordinate it can resolve directly in ClearlyDefined.

Result: Registrations went from 35 accepted (4 rejected) → 44 accepted (0 rejected). GSL and nlohmann::json now appear in the generated NOTICE.txt. yaml-cpp and boost will appear once their ClearlyDefined harvests complete (~2 weeks, already triggered).

Validation Steps Performed

  1. Pushed branch  user/beenachauhan/fix-cgmanifest-hash  and ran  wsl-github-notice  pipeline manually (run #20260707.8, commit  107e2571 ).
  2. Confirmed "Submitted 44 registrations" with zero  Parameter name: 'Hash'  warnings.
  3. Downloaded NOTICE.txt artifact (83,498 bytes, up from 78,779) and verified:
    •  microsoft/gsl a3534567... - MIT license present
    •  nlohmann/json 55f93686... - MIT license present
  4. Confirmed yaml-cpp appears in "Not harvested in ClearlyDefined" (expected - harvest pending, no code fix needed).

Copilot AI review requested due to automatic review settings July 8, 2026 05:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Component Governance manifest to unblock CG registration and improve NOTICE/license resolution for several third-party OSS components by using accepted hash formats and adding git coordinates.

Changes:

  • Changed type: "other" component hashes for boost, yaml-cpp, GSL, and nlohmann/json from sha256: to sha1: format.
  • Added type: "git" registrations (repositoryUrl + commitHash) for yaml-cpp, GSL, and nlohmann/json to support notice/license resolution pipelines.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@beena352
beena352 marked this pull request as ready for review July 8, 2026 18:33
@beena352
beena352 requested a review from a team as a code owner July 8, 2026 18:33

@OneBlue OneBlue left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor question

Comment thread cgmanifest.json
@beena352
beena352 merged commit 487bce1 into master Jul 20, 2026
13 checks passed
@beena352
beena352 deleted the user/beenachauhan/fix-cgmanifest-hash branch July 20, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants