Skip to content

Texturing: make the keep-existing-UVs path reachable (and non-crashing once it is) #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xocialize wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Texturing: make the keep-existing-UVs path reachable (and non-crashing once it is) #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions trellis2/pipelines/trellis2_texturing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ def preprocess_mesh(self, mesh: trimesh.Trimesh) -> trimesh.Trimesh:
vertices[:, 1] = -vertices[:, 2]
vertices[:, 2] = tmp
assert np.all(vertices >= -0.5) and np.all(vertices <= 0.5), 'vertices out of range'
return trimesh.Trimesh(vertices=vertices, faces=mesh.faces, process=False)
# Carry the visual through so postprocess_mesh's keep-existing-UVs branch is reachable
# (vertex order is unchanged, so per-vertex UVs stay valid).
return trimesh.Trimesh(vertices=vertices, faces=mesh.faces, visual=mesh.visual, process=False)

def preprocess_image(self, input: Image.Image) -> Image.Image:
"""
Expand Down Expand Up @@ -291,9 +293,11 @@ def postprocess_mesh(
resolution: int = 1024,
texture_size: int = 1024,
) -> trimesh.Trimesh:
vertices = mesh.vertices
faces = mesh.faces
normals = mesh.vertex_normals
# Copies: trimesh caches (vertex_normals) are read-only, and the axis swap below
# writes in place — only the uv-unwrap branch replaced these with fresh arrays.
vertices = np.array(mesh.vertices)
faces = np.array(mesh.faces)
normals = np.array(mesh.vertex_normals)
vertices_torch = torch.from_numpy(vertices).float().cuda()
faces_torch = torch.from_numpy(faces).int().cuda()
if hasattr(mesh, 'visual') and hasattr(mesh.visual, 'uv') and mesh.visual.uv is not None:
Expand Down