Fix unreadable What's New titles/links when OS and PowerToys themes differ - #48910
Merged
Conversation
…iffer The release-notes (Scoobe) page uses the CommunityToolkit MarkdownTextBlock, which captures its heading and link brushes from Application.Current.Resources, resolving them against the OS (application) theme instead of the window's selected theme. When the OS theme differs from the PowerToys theme, headings and hyperlinks render with unreadable colors, and the system caption buttons aren't tinted to match. Workarounds (until CommunityToolkit/Labs-Windows#785 lands upstream): - Pin the MarkdownTextBlock RequestedTheme and reassign H1-H6 + link brushes resolved for the selected theme before rendering, and re-apply on runtime theme changes. - Add a shared TitleBarHelper to tint the system caption buttons to the window's actual theme (ScoobeWindow uses the built-in WinUI TitleBar, which doesn't do this). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
Area-Localization
niels9001
added
Product-Settings
Collaborator
Author
|
@crutkas you were running into this issue too, right? |
jiripolasek
approved these changes
Jun 29, 2026
jiripolasek
left a comment
jiripolasek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
I was able to reproduce the issue without the fix and verify that it no longer occurs with this change applied. HC themes also work fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When the OS theme differs from the PowerToys theme (e.g. OS in Light, PowerToys set to Dark), the What's New / release-notes (Scoobe) page renders heading titles and hyperlinks with brushes pinned to the wrong theme, making them unreadable. The system caption buttons (min/max/close) are also not tinted to match the window theme.
The release-notes page uses the CommunityToolkit
MarkdownTextBlock, which captures its heading and link brushes fromApplication.Current.Resourceswhen its theme config is created. Those resolve against the OS (application) theme rather than the window's selected element theme, so headings/links break whenever the two themes differ.PR Checklist
Detailed Description of the Pull Request / Additional comments
These are deliberately local workarounds until the upstream control resolves brushes against the element theme via CommunityToolkit/Labs-Windows#785. Comments +
TODOs in the code point at that PR so the workaround can be removed once it ships.ScoobeReleaseNotesPageMarkdownTextBlock.RequestedThemeto the selected app theme and reassign theH1–H6heading brushes and the link brush (resolved for that theme) before the markdown is rendered. The themed brushes are read from the control's ownForeground(TextFillColorPrimaryBrush) and a hiddenLinkBrushProvidercarrier element (AccentTextFillColorPrimaryBrush).ActualThemeChanged), so titles/links stay readable when the user switches Light/Dark while the window is open.TitleBarHelper(new) +ScoobeWindowTitleBarHelper.ApplySystemThemeToCaptionButtons(window, theme)(port of the WinUI Gallery helper + PowerToys conventions) and drive the Scoobe window's caption-button colors from the content's actual theme, updating onActualThemeChanged.ScoobeWindowuses the built-in WinUITitleBar, which — unlike the custom PowerToysTitleBarcontrol used by the other Settings windows — does not tint the system caption buttons to the app theme.Validation Steps Performed
OS is in Light Mode, while the app settings are set to Dark mode