Repository navigation
Unify TypeScript 6 toolchain and fix Windows validation - #318
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Explicitly include Node.js types for the instance and profile registry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate docs aliases away from baseUrl, declare SSR Node types, and remove the unused TypeScript 5 lockfile entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover both default cmd.exe and an explicit ComSpec path without depending on the host environment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Close SQLite connections before removing fixtures and normalize paths when registering the harness contract tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scope the available Undici 6.29.0 release to node-gyp, refresh packaging snapshots, and preserve existing package integrity metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Packaging dependency changes require human review while macOS packaging and ESRP signing validation remain pending.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Aligns the workspace TypeScript toolchain and addresses Windows validation and dependency-restore failures.
Changes:
- Standardizes TypeScript on 6.0.3, with explicit Node types and updated documentation aliases.
- Fixes SQLite test cleanup, Windows path comparisons, and shell environment isolation.
- Pins node-gyp’s Undici dependency and documents packaging constraints.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds scoped Undici override. |
| pnpm-lock.yaml | Unifies compiler resolution and refreshes packaging dependencies. |
| external/agentlet/packages/protocol/package.json | Upgrades TypeScript. |
| external/agentlet/packages/local/tests/harnesses.test.ts | Isolates and tests ComSpec variants. |
| external/agentlet/packages/local/package.json | Upgrades TypeScript. |
| external/agenetes/packages/runtime/package.json | Upgrades TypeScript. |
| external/agenetes/packages/protocol/package.json | Upgrades TypeScript. |
| external/agenetes/packages/pi-driver/package.json | Upgrades TypeScript. |
| external/agenetes/packages/agentlet-host/package.json | Upgrades TypeScript. |
| external/agenetes/packages/agentlet-gateway/package.json | Upgrades TypeScript. |
| external/agenetes/packages/agent-profile/tsconfig.json | Explicitly includes Node types. |
| external/agenetes/packages/agent-profile/package.json | Upgrades TypeScript. |
| external/agenetes/packages/agenetes/tsconfig.json | Explicitly includes Node types. |
| external/agenetes/packages/agenetes/src/turn-store.test.ts | Closes SQLite stores before cleanup. |
| external/agenetes/packages/agenetes/src/store-harness.test.ts | Normalizes Windows test paths. |
| external/agenetes/packages/agenetes/package.json | Upgrades TypeScript. |
| external/agenetes/packages/acp-driver/package.json | Upgrades TypeScript. |
| docs/architecture/desktop-auto-update.md | Documents compiler and packaging constraints. |
| apps/docs/tsconfig.json | Updates alias resolution and Node types. |
| apps/docs/package.json | Upgrades TypeScript. |
Review effort: Balanced
Resolve the lockfile conflict by retaining main's Undici upgrades alongside the TypeScript 6 toolchain and scoped node-gyp override. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Reported inherited Undici availability failures block fresh post-merge installation and typechecking, leaving the final toolchain unvalidated.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge validation status
Merged
origin/mainat26917e87and resolved the lockfile conflict without downgrading main's dependencies or rewriting existing commits. All sixteen TypeScript compiler bindings remain at 6.0.3, main's runtime Undici 7.30.1 and testcontainers Undici 8.12.2 are retained, and the node-gyp-only Undici 6.29.0 override remains intact.Current validation is blocked by inherited main dependency availability:
pnpm install --frozen-lockfile --prefer-offlinereturns HTTP 404 forundici@7.30.1; explicit official-registry metadata lookups for both 7.30.1 and 8.12.2 also return 404 in this environment. Consequently the fresh typecheck stops atapps/server/src/setup-proxy.tswith a missingundicimodule. These versions were retained rather than silently downgraded.Frozen offline lockfile/manifest consistency, lockfile formatting, semantic dependency assertions, and conflict-marker/index checks pass. The successful build and test results below describe validation before this main merge, not a claim that the current full dependency restore is green.
Summary
Unify the directly controlled TypeScript toolchain on 6.0.3 and repair the Windows validation and dependency-restore failures found during the upgrade.
^6.0.3, matching the existing Huabu workspaces, and remove TypeScript 5 from the root lockfile.baseUrl.ComSpecassertions while covering both the default and explicit shell paths.Validation
pnpm install --frozen-lockfile --ignore-scripts --prefer-offlinepasses; complete installation and workspace postinstall builds also passed.pnpm typecheckpasses across all workspaces, including its prerequisite subtree and client-runtime builds.pnpm formatpasses without additional changes.pnpm lint:fixpasses with 0 errors and 330 warnings, without additional changes.Scope and follow-up
The local Node.js installation and EBOM workbook update are not repository changes and are not included in this PR. No release tag or installer publication is performed. macOS packaging and ESRP signing still require validation in Azure DevOps; a complete signed release was not produced locally.