Repository navigation
Fix desktop startup by packaging built-in Service resources - #316
Merged
Merged
Conversation
Include Service manifests and runtime files in desktop packages, add an isolated bundle regression test, and document the packaging contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused packaging fix matches loader expectations and includes regression coverage; reported validation was not independently rerun.
No open issues 🎉
What changed in this PR
Fixes packaged desktop startup by including the built-in Service resources required during server initialization.
Changes:
- Packages Service resources while excluding test source files.
- Adds isolated loading and content-hash regression coverage.
- Documents the desktop Service packaging contract.
| File | Description |
|---|---|
| docs/architecture/service-packages.md | Documents resource layout and startup requirements. |
| apps/server/src/bundle.test.ts | Tests resource mapping, exclusions, and isolated Service loading. |
| apps/desktop/electron-builder.yml | Includes Service resources in desktop packages. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix packaged desktop startup failing with
Server process exited before becoming ready (code=1, signal=null)because bundled Service resources were missing from the installer.dist-bundle/servicesintoresources/server/servicesalongside the server bundle.*.test.*source files while preserving Service manifests, skills, and runtime entry files.Root cause
The server build already copies Service resources, but electron-builder did not include them. During startup, the Service loader falls back to the source layout and throws
ENOENTforservices/image-gen/service.yaml, terminating the server before readiness.Validation
pnpm typecheckpnpm format(no additional changes)pnpm lint:fix(0 errors, 330 warnings; no additional changes)The installer smoke test used an unsigned local build. The Windows install wizard, existing-user-data upgrade, macOS/Linux startup, and ESRP signing were not exercised. Signing configuration and credential handling are unchanged.