Skip to content

Make UnalignedSlice Send and Sync. #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mark Hildebrand (hildebrandmw) merged 2 commits into from
Aug 24, 2026
Merged

Make UnalignedSlice Send and Sync. #1348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a74727
Make `UnalignedSlice` Send and Sync.
Aug 21, 2026
cee6bb0
Copilot correction
hildebrandmw Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions diskann-vector/src/unaligned.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ pub struct UnalignedSlice<'a, T> {
_lifetime: PhantomData<&'a T>,
}

/// SAFETY: `UnalignedSlice` is like a `&[T]`: it can be sent to other threads when `&T: Send`,
/// which holds iff `T: Sync`.
unsafe impl<T> Send for UnalignedSlice<'_, T> where T: Sync {}

/// SAFETY: `UnalignedSlice` is like a `&[T]`: it can be shared with other threads when `&T`
/// is send, implying the bound `T: Sync`.
unsafe impl<T> Sync for UnalignedSlice<'_, T> where T: Sync {}

impl<'a, T> UnalignedSlice<'a, T> {
/// Construct a new [`UnalignedSlice`] over the region `[ptr, ptr.add(len))`.
///
Expand Down
Loading