Skip to content

Preserve quant compressor API for explicit PQ generation - #1321

Merged
xwj-ox merged 1 commit into
codex/explicit-pq-pivots-1016from
codex/pr-1299-no-api-change-pivots
Aug 13, 2026
Merged

Preserve quant compressor API for explicit PQ generation#1321
xwj-ox merged 1 commit into
codex/explicit-pq-pivots-1016from
codex/pr-1299-no-api-change-pivots

Conversation

@xwj-ox

@xwj-ox xwj-ox commented Aug 12, 2026

Copy link
Copy Markdown
  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies? No.
  • Does this PR modify any existing APIs? No public API changes; this preserves the existing constructor-based quant generation API.
  • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones? No.

Reference Issues/PRs

Follow-up to #1299.

What does this implement/fix? Briefly explain your changes.

Preserves the existing quant compressor and quant data generator API while keeping disk-search PQ pivot generation explicit inside DiskIndexBuilder. This removes the lazy generate(&self) lifecycle and OnceLock path introduced in #1314-style changes, avoiding the concurrent initialization race without adding a mutex or public API.

Any other comments?

Verification:

  • cargo fmt --all --check
  • cargo test -p diskann-disk
  • cargo clippy -p diskann-disk --all-targets -- -D warnings

@xwj-ox
xwj-ox merged commit d226afa into codex/explicit-pq-pivots-1016 Aug 13, 2026
1 check passed
@xwj-ox
xwj-ox deleted the codex/pr-1299-no-api-change-pivots branch August 13, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants