Pin starlette in API requirements.txt - #5043
Open
Marcus Robinson (marrobi) with Copilot wants to merge 6 commits into
Open
Pin starlette in API requirements.txt#5043Marcus Robinson (marrobi) with Copilot wants to merge 6 commits into
Marcus Robinson (marrobi) with Copilot wants to merge 6 commits into
Conversation
Co-authored-by: marrobi <17089773+marrobi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing Starlette dependency in requirements.txt
Pin starlette in API requirements.txt
Aug 17, 2026
Marcus Robinson (marrobi)
approved these changes
Aug 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the API’s direct Starlette dependency for reproducible dependency resolution.
Changes:
- Pins Starlette 1.3.1.
- Bumps API patch version to 0.26.6.
- Documents the fix in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CHANGELOG.md |
Adds the bug-fix entry. |
api_app/requirements.txt |
Pins Starlette 1.3.1. |
api_app/_version.py |
Bumps the API version. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 38e1f36. ♻️ This comment has been updated with latest results. |
Copilot started reviewing on behalf of
Jack Morris (rudolphjacksonm)
August 26, 2026 12:44
View session
Copilot started reviewing on behalf of
Jack Morris (rudolphjacksonm)
August 27, 2026 10:22
View session
Collaborator
|
Copilot bump the api version |
Co-authored-by: rudolphjacksonm <13438569+rudolphjacksonm@users.noreply.github.com>
Contributor
Author
Addressed in |
Collaborator
|
/test fa38180 |
Jack Morris (rudolphjacksonm)
enabled auto-merge (squash)
August 27, 2026 10:38
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/33063905112 (with refid (in response to this comment from Jack Morris (@rudolphjacksonm)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5036
What is being addressed
api_app/main.pyimports Starlette directly (starlette.exceptions.HTTPException,starlette.middleware.errors.ServerErrorMiddleware), but Starlette was not listed inapi_app/requirements.txt. Its version was only resolved transitively via FastAPI, leaving it unpinned and uncontrolled.How is this addressed
starlette==1.3.1inapi_app/requirements.txt— the version referenced in prior PR Bump starlette, fastapi, opentelemetry, add additional test coverage #5032 and compatible with the pinnedfastapi==0.139.2(starlette>=0.46.0).0.26.5→0.26.7(patch).CHANGELOG.md.