Skip to content

Upload to the ESP component registry - #378

Open
Narukara wants to merge 1 commit into
kiltedfrom
feat/upload_esp_registry
Open

Upload to the ESP component registry#378
Narukara wants to merge 1 commit into
kiltedfrom
feat/upload_esp_registry

Conversation

@Narukara

@Narukara Narukara commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

See #369

Publish Kilted as version 25.0.0.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@Narukara, all pull requests must be targeted towards the rolling development branch.
Once merged into rolling, it is possible to backport to kilted, but it must be in rolling
to have these changes reflected in new distributions.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Narukara
Narukara force-pushed the feat/upload_esp_registry branch from 667746d to bbc54dd Compare August 6, 2026 04:01

@Amronos Amronos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks good to me. Before merging this PR, do we need a component with the name micro-ros/micro_ros_espidf_component created in the ESP component registry, or has that already been done? cc: @EugenioCollado

@Narukara

Narukara commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

do we need a component with the name micro-ros/micro_ros_espidf_component created in the ESP component registry

I had the same concern. The MR CI dry run passed, but it appears that upload-components-ci-action does not validate permissions in dry-run mode. We should still confirm this with him.

@Narukara

Narukara commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Another minor issue is that the banner in the README does not render correctly in the registry. It may need to use a URL such as https://raw.githubusercontent.com/.... Also, switching images based on the light or dark theme is somewhat difficult in the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants