Fix job race condition and guard exit callbacks - #265
Open
aphroteus wants to merge 1 commit into
Open
Conversation
When initiating a new search while a previous job is running, stdout and exit callbacks from superseded jobs continue to execute because 's:id' is overwritten, polluting the quickfix list. Additionally, if tabs or windows are closed during an async search, restoring focus using static window numbers throws errors or focuses the wrong window. - Assign a monotonic job_id to each task and discard callbacks from superseded jobs - Use win_gotoid() for precise window/tab restoration with bounds-checked fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initiating a new search while a previous job is running, stdout and exit callbacks from superseded jobs continue to execute because 's:id' is overwritten, polluting the quickfix list.
Additionally, if tabs or windows are closed during an async search, restoring focus using static window numbers throws errors or focuses the wrong window.