Extend reitit.walk keywordize to IPersistentVector - #796
Open
The-Alchemist wants to merge 1 commit into
Open
Conversation
Protocol extend is exact-class, so subvec (APersistentVector$SubVector) and other IPersistentVector implementations skipped keywordize-keys and disagreed with clojure.walk. Match the existing IPersistentMap fallback. Signed-off-by: Karl Pietrzak <karl@medplum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reitit.walkextendsIKeywordizetoPersistentVectorby exact class.subvec(APersistentVector$SubVector) and otherIPersistentVectorimplementations therefore fall through toObjectand are not walked, sokeywordize-keysdisagrees withclojure.walk.clojure.lang.IPersistentVectorinstead, matching the existingIPersistentMapfallback.PersistentVectorbehavior is unchanged.keywordize-subvecregression test (gen/any-equatablenever produces subvecs).Motivation
Cloffle is a Truffle/GraalVM implementation of Clojure. Its small vectors are
PersistentTuple(IPersistentVector, notPersistentVector), soreitit.walk/keywordize-keysskipped nested maps inside(vector …)whileclojure.walkdid not. The same exact-class gap shows up on JVM Clojure withsubvec. ExtendingIPersistentVectorcovers both.