Repository navigation
docs(wiki): say the A2 message is written to the live region, not that it is spoken - #60
Merged
Merged
Conversation
…t it is spoken Feature-Status claimed the group-sync change is "announced once to screen readers". The tests read the status region's text under happy-dom; no screen-reader run has confirmed speech (A1). Raised by CodeRabbit on #58. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tmsGh5n4GwJZYq9Z5mtxH
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes one sentence in
docs/wiki/users/Feature-Status.adoc, a follow-up to #58 raised by CodeRabbit on that PR (comment 4198167436).role="status"live region (RELEASE-CRITERIA A2); that a screen reader speaks it is not yet verified (A1)."The A2 tests read the region's text under happy-dom. No screen-reader run has confirmed speech, so the page no longer claims it.
Closes # — no issue; this is review follow-up to #58.
Type of change
📌 New pins
How has this been verified?
./tools/check-wiki-health.sh: PASS (9 registered pages).bun test. The last full run, on feat(a11y): announce variant changes made by group sync (A2) #58's head, was 86 pass, 0 fail.Checklist
git log -1 --format=%G?→G.Notes for reviewers
let listeningAcrossTabsabove thelistenAcrossTabs()docstring, so the docstring attaches to the function. The change is correct and touches a different file from this PR, so the two do not conflict. I left fix: CodeRabbit auto-fixes for PR #58 #59 as its own PR for you to merge or close.🤖 Generated with Claude Code
https://claude.ai/code/session_019tmsGh5n4GwJZYq9Z5mtxH