Repository navigation
fix(wiki): publish pages as .asciidoc, which the GitHub wiki lists - #56
Merged
Merged
Conversation
The first publish wrote .adoc pages and the wiki listed none of them (curl of /wiki/_pages: 0 page links; asciidoctor/asciidoctor's wiki, which uses .asciidoc, lists its pages). The cleanup now also removes stray .adoc and .asciidoc pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tmsGh5n4GwJZYq9Z5mtxH
7 of 13 tasks
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Autopilot could not be updated. Open Coding to check access and billing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #55. That PR merged at its first head,
7708ba8, before this fix was pushed to its branch.tools/publish-wiki.mjson main writes.adocpages, and the GitHub wiki lists none of them:curl …/wiki/_pagesreturned 0 page links after that publish. The asciidoctor/asciidoctor wiki uses.asciidocand lists its pages. This PR changes the output extension to.asciidoc, exported asPAGE_EXT. It also widenswriteWiki's cleanup to remove stray.md,.adocand.asciidocpages, so a republish clears the earlier.adocfiles.Closes # — no issue; this finishes DEBT D2 / RELEASE-CRITERIA D2's wiki half, landed in #55.
Type of change
tools/publish-wiki.mjs.📌 New pins
Head SHA: 1a9182c. This PR adds or changes no pins: no action
uses:, noactions.lockentries, no lockfile records and no container digests.How has this been verified?
bun test: 78 pass, 0 fail, including a new assertion onPAGE_EXTand a stale.adocpage removed bywriteWiki.e43022awas published by this exact code (branch commit4f89ba1, cherry-picked here as1a9182c). Checked with curl:_pageslists all 11 pages.WIKI-HOME-001, with no literal{page-*}and noinclude::.Checklist
%G?=G.SPDX-License-Identifier: there are no new files; both edited files keep theirMPL-2.0headers.Notes for reviewers
After this merges, the wiki will be republished from the squash commit, so that each page's source note names a commit on
main.🤖 Generated with Claude Code
https://claude.ai/code/session_019tmsGh5n4GwJZYq9Z5mtxH