fully type safe hotdoc module#15790
Merged
Merged
Conversation
dcbaker
force-pushed
the
submit/type-hotdoc
branch
from
a1f137d to
8b66148
Compare
bonzini
reviewed
May 9, 2026
Also, remove the unused HotdocTargetBuilder.extra_assets
Mainly this is due to deleting fields (requires Total=False), and the fact that Python cannot (yet) represent arbitrary keys. I've just type: ignored those issues for now and we can revisit when PEP 728 is implemented and Python can represent that. Also, make the build_by_default parameter explicit
dcbaker
force-pushed
the
submit/type-hotdoc
branch
from
8b66148 to
5f94c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last of the modules, with this done all modules are type safe!