Skip to content

fix: resolve duplicate error code in meshkit #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parthivsaikia wants to merge 3 commits into
base: master
Choose a base branch
from
+33 −25
Open

fix: resolve duplicate error code in meshkit #904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa2532
fix: resolve duplicate error code in meshkit
parthivsaikia Jan 8, 2026
3270262
fix: fix .golangci.yml configuration
parthivsaikia Jan 8, 2026
710c258
lint: disable ST1000, ST1003, ST1005, ST1016, ST1020, ST1021, ST1022 …
parthivsaikia Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .golangci.yml
View file
Open in desktop

@lekaf974 lekaf974 Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding more exceptions ?

Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,19 @@ version: "2"

run:
timeout: 5m
go: "1.25"

linters-settings:
staticcheck:
go: "1.25"
checks: ["all", "-ST1005"]

issues:
exclude:
- "ST1005"
linters:
settings:
staticcheck:
checks:
[
"all",
"-ST1000",
"-ST1003",
"-ST1005",
"-ST1016",
"-ST1020",
"-ST1021",
"-ST1022",
]
10 changes: 5 additions & 5 deletions encoding/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ import (
)

const (
ErrDecodeYamlCode = "meshkit-11245"
ErrUnmarshalCode = "meshkit-11246"
ErrUnmarshalInvalidCode = "meshkit-11247"
ErrUnmarshalSyntaxCode = "meshkit-11248"
ErrUnmarshalTypeCode = "meshkit-11249"
ErrDecodeYamlCode = "meshkit-11321"
ErrUnmarshalCode = "meshkit-11328"
ErrUnmarshalInvalidCode = "meshkit-11329"
ErrUnmarshalSyntaxCode = "meshkit-11323"
ErrUnmarshalTypeCode = "meshkit-11330"
Comment thread
parthivsaikia marked this conversation as resolved.
ErrUnmarshalUnsupportedTypeCode = "meshkit-11250"
ErrUnmarshalUnsupportedValueCode = "meshkit-11251"
)
Expand Down
2 changes: 1 addition & 1 deletion files/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ func ErrDecodePattern(err error) error {
}

var (
ErrInvalidModelCode = "meshkit-11301"
ErrInvalidModelCode = "meshkit-11331"
ErrInvalidModelArchiveCode = "meshkit-11302"
ErrEmptyModelCode = "meshkit-11303"
)
Expand Down
5 changes: 3 additions & 2 deletions helpers/component_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "meshkit",
"type": "library",
"next_error_code": 11320
}
"next_error_code": 11335
}

2 changes: 1 addition & 1 deletion models/converter/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
)

const (
ErrUnknownFormatCode = "meshkit-11245"
ErrUnknownFormatCode = "meshkit-11320"
)

func ErrUnknownFormat(format DesignFormat) error {
Expand Down
2 changes: 1 addition & 1 deletion models/meshmodel/entity/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
)

const (
ErrUpdateEntityStatusCode = "meshkit-11243"
ErrUpdateEntityStatusCode = "meshkit-11327"
)

func ErrUpdateEntityStatus(err error, entity string, status EntityStatus) error {
Expand Down
6 changes: 3 additions & 3 deletions registry/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (
)

var (
ErrAppendToSheetCode = "meshkit-11302"
ErrUpdateToSheetCode = "meshkit-11303"
ErrGeneratesModelCode = "meshkit-11305"
ErrAppendToSheetCode = "meshkit-11332"
ErrUpdateToSheetCode = "meshkit-11333"
ErrGeneratesModelCode = "meshkit-11334"
ErrCSVFileNotFoundCode = "meshkit-11307"
ErrUpdateComponentsCode = "meshkit-11308"
ErrGeneratesComponentCode = "meshkit-11309"
Expand Down
4 changes: 2 additions & 2 deletions utils/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ var (
ErrRelPathCode = "meshkit-11275"
ErrCopyFileCode = "meshkit-11276"
ErrCloseFileCode = "meshkit-11277"
ErrCompressToTarGZCode = "meshkit-11248"
ErrCompressToTarGZCode = "meshkit-11322"

ErrConvertToByteCode = "meshkit-11187"
ErrConvertToByteCode = "meshkit-11324"

ErrOpenFileCode = "meshkit-11278"

Expand Down
2 changes: 1 addition & 1 deletion utils/kubernetes/expose/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

var (
// ErrExposeResourceCode is generated while exposing the kubernetes resource
ErrExposeResourceCode = "meshkit-11205"
ErrExposeResourceCode = "meshkit-11325"

// ErrGettingResourceCode is generated when there is an error getting the kubernetes resource
ErrGettingResourceCode = "meshkit-11206"
Expand Down
2 changes: 1 addition & 1 deletion utils/kubernetes/kompose/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const (
ErrValidateDockerComposeFileCode = "meshkit-11230"
ErrIncompatibleVersionCode = "meshkit-11231"
ErrNoVersionCode = "meshkit-11232"
ErrMultipleDocumentsCode = "meshkit-11233"
ErrMultipleDocumentsCode = "meshkit-11326"
)

func ErrCvrtKompose(err error) error {
Expand Down
Loading