Repository navigation
Conversation
CI installs .[dev] for mypy and tests, and dev pulled in the doc extra, so every job built quarto-cli from its sdist (it has no wheel) and installed Jupyter with it. No CI job uses Quarto. The doc extra stays for docs builds: make sync installs it, and pip users add .[dev,doc]. Refs meridianlabs-ai/inspect-docs#7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dragonstyle
requested changes
Oct 21, 2026
dragonstyle
left a comment
Member
There was a problem hiding this comment.
🤖 Automated review (CASE) at 95cc49e4df
The change is right: CI and agent workflows install .[dev] for mypy and tests, nothing in src, tests or examples imports a docs package, make sync still installs [doc], and the README/CONTRIBUTING instructions are correct. One small note, inline.
…labs-ai-inspect-docs-7-r
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs meridianlabs-ai/inspect-docs#7
The
[dev]extra included[doc], so the CI mypy and test jobs (pip install .[dev]) builtquarto-clifrom its sdist on every run and installed Jupyter with it. No CI job uses Quarto.Changes
pyproject.toml: dropinspect_swe[doc]fromdev. Thedocextra is unchanged.uv.lock: relocked. Thedevextra's entries drop the docs packages; uv 0.12.5 also reordered tworesolution-markerslines, which changes no resolved package or version (the next relock with a different uv may flip them back).CONTRIBUTING.md,README.md: say how to get the docs packages:make sync(already--all-extras), orpip install -e ".[dev,doc]".No Makefile or workflow change is needed.
make syncalready installs every extra. The repo has nomake docstarget and no docs workflow: the site is served from thegh-pagesbranch, published by hand.Verification
pip install --dry-run .[dev](the CI command) on Python 3.11 and 3.14: noquarto-cli, and no package resolves to an sdist.pip install --dry-run .[dev,doc]on 3.14:quarto-cli1.10.19 is still installed.uv export --frozen --extra dev: noquarto-cli;--all-extrasstill has it.pip install .[dev](no docs packages):mypypasses andpytest --cocollects 488 tests.make syncstill installsquarto,griffe,panfluteandmarkdown;ruff format --check,ruff checkandmypypass.The nightly slow tests in
meridianlabs-ai/actionsalso install.[dev], so they stop installing Quarto too.Agent jobs
The agent jobs (
claude.yml,claude-auto.yml,claude-review.yml) are covered by this change with no edit to them. They set noprovisionrecipe, so the shared agent workflows installuv venv && uv pip install -e ".[dev]", which no longer pulls in the docs packages. A lateruv runby the agent installs no extras, so it doesn't add them back either. A simulation of both steps (clean environment, uv 0.12.18 as the provisioner installs it) foundquarto-cliinstalled onmainand absent at this branch's head after each step. This PR doesn't depend on any change in the agents repo.🤖 Generated with Claude Code
Agent review
Regression analysis (aggregator, pass 1)
.[dev]users building docs.[dev,doc]to regain docs tools.CONTRIBUTING.md:53andREADME.md:23. Cost: one explicit extra when building docs.Risk areas
Not traced