Skip to content

build: keep the docs packages out of the dev extra - #204

Open
ransomr wants to merge 2 commits into
mainfrom
task-part-of-meridianlabs-ai-inspect-docs-7-r
Open

ransomr wants to merge 2 commits into
mainfrom
task-part-of-meridianlabs-ai-inspect-docs-7-r

Conversation

@ransomr

@ransomr ransomr commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Refs meridianlabs-ai/inspect-docs#7

The [dev] extra included [doc], so the CI mypy and test jobs (pip install .[dev]) built quarto-cli from its sdist on every run and installed Jupyter with it. No CI job uses Quarto.

Changes

  • pyproject.toml: drop inspect_swe[doc] from dev. The doc extra is unchanged.
  • uv.lock: relocked. The dev extra's entries drop the docs packages; uv 0.12.5 also reordered two resolution-markers lines, which changes no resolved package or version (the next relock with a different uv may flip them back).
  • CONTRIBUTING.md, README.md: say how to get the docs packages: make sync (already --all-extras), or pip install -e ".[dev,doc]".

No Makefile or workflow change is needed. make sync already installs every extra. The repo has no make docs target and no docs workflow: the site is served from the gh-pages branch, published by hand.

Verification

  • pip install --dry-run .[dev] (the CI command) on Python 3.11 and 3.14: no quarto-cli, and no package resolves to an sdist.
  • pip install --dry-run .[dev,doc] on 3.14: quarto-cli 1.10.19 is still installed.
  • uv export --frozen --extra dev: no quarto-cli; --all-extras still has it.
  • In a fresh Python 3.11 venv with pip install .[dev] (no docs packages): mypy passes and pytest --co collects 488 tests.
  • make sync still installs quarto, griffe, panflute and markdown; ruff format --check, ruff check and mypy pass.

The nightly slow tests in meridianlabs-ai/actions also install .[dev], so they stop installing Quarto too.

Agent jobs

The agent jobs (claude.yml, claude-auto.yml, claude-review.yml) are covered by this change with no edit to them. They set no provision recipe, so the shared agent workflows install uv venv && uv pip install -e ".[dev]", which no longer pulls in the docs packages. A later uv run by the agent installs no extras, so it doesn't add them back either. A simulation of both steps (clean environment, uv 0.12.18 as the provisioner installs it) found quarto-cli installed on main and absent at this branch's head after each step. This PR doesn't depend on any change in the agents repo.

🤖 Generated with Claude Code

Agent review

  • Reviewers: Codex gpt-6.1-sol (xhigh reasoning) and Claude Opus 5.5 (high effort), each in a fresh, clean context with a short review prompt and no history of the loop. Each new head gets a first pass of Codex and Claude reviewers side by side; when nothing they found is kept, more run in parallel to confirm, Codex and Claude side by side. A separate Codex gpt-6.1-sol (xhigh reasoning) session that keeps the loop's history checks every finding against the code, decides what is raised, and writes the verdict and the regression analysis. 1 pass, all separate from the implementer (Claude Code).
  • Pass 1: first pass, 2 reviewers (1 Codex gpt-6.1-sol, 1 Claude Opus 5.5): 0/0 findings; confirming batch, 6 reviewers (3 Codex gpt-6.1-sol, 3 Claude Opus 5.5): 0/0/0/0/0/0 findings; aggregator: 0 Blocking, 0 Optional, 0 Questions; verdict clean
  • Outcome: PR description fixed in fix turn 2; not re-reviewed

Regression analysis (aggregator, pass 1)

Surface What changes for it Evidence Verdict
Existing pip .[dev] users building docs Must explicitly install .[dev,doc] to regain docs tools. Required by the task; migration instructions at CONTRIBUTING.md:53 and README.md:23. Cost: one explicit extra when building docs. decision

Risk areas

  • none

Not traced

  • none

CI installs .[dev] for mypy and tests, and dev pulled in the doc extra,
so every job built quarto-cli from its sdist (it has no wheel) and
installed Jupyter with it. No CI job uses Quarto. The doc extra stays
for docs builds: make sync installs it, and pip users add .[dev,doc].

Refs meridianlabs-ai/inspect-docs#7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ransomr
ransomr marked this pull request as ready for review October 21, 2026 14:36
@ransomr
ransomr requested a review from dragonstyle October 21, 2026 14:36

@dragonstyle dragonstyle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review (CASE) at 95cc49e4df

The change is right: CI and agent workflows install .[dev] for mypy and tests, nothing in src, tests or examples imports a docs package, make sync still installs [doc], and the README/CONTRIBUTING instructions are correct. One small note, inline.

Comment thread uv.lock
@ransomr
ransomr requested a review from dragonstyle October 21, 2026 17:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants