feat: support building on FreeBSD#86
Open
Ignition wants to merge 1 commit into
Open
Conversation
Accept FreeBSD in the CMake OS check and reuse the existing POSIX socket path (src/linux/). Two source portability fixes make that path compile on FreeBSD: - endian: FreeBSD provides the byte-order helpers via <sys/endian.h> rather than glibc's <endian.h>. - SOL_TCP: use the portable POSIX IPPROTO_TCP for TCP-level setsockopt options; SOL_TCP is a Linux-only alias (equal to IPPROTO_TCP there). Also rename the MGCLIENT_ON_LINUX macro/CMake variable to MGCLIENT_ON_POSIX, since Linux and FreeBSD now share that build path. Verified: static and shared libraries build with clang on FreeBSD 14.
mattkjames7
reviewed
Jul 17, 2026
| #ifndef MGCLIENT_LINUX_MGCOMMON_H | ||
| #define MGCLIENT_LINUX_MGCOMMON_H | ||
|
|
||
| #if defined(__FreeBSD__) |
Contributor
There was a problem hiding this comment.
We could extend this to support other BSD builds, e.g. this from Boost:
#if !defined(__FreeBSD__) && !defined(__NetBSD__) && !defined(__OpenBSD__) && !defined(__DragonFly__)
mattkjames7
reviewed
Jul 17, 2026
| message(STATUS "ON LINUX WASM BUILD") | ||
| elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| message(STATUS "ON LINUX BUILD") | ||
| elseif(CMAKE_SYSTEM_NAME STREQUAL "FreeBSD") |
Contributor
There was a problem hiding this comment.
same as above- we could include other BSDs: https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_NAME.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept FreeBSD in the CMake OS check and reuse the existing POSIX socket path (src/linux/). Two source portability fixes make that path compile on FreeBSD:
rather than glibc's <endian.h>.
Also rename the MGCLIENT_ON_LINUX macro/CMake variable to MGCLIENT_ON_POSIX, since Linux and FreeBSD now share that build path.
Verified: static and shared libraries build with clang on FreeBSD 14.