Repository navigation
fix: support signed composition offsets - #141
Merged
varsill merged 3 commits intoSep 24, 2026
Merged
Conversation
- write ctts version 1 when ISOM offsets are negative - write trun version 1 for negative CMAF offsets - cover signed H265 muxing, parsing, and transmuxing
varsill
approved these changes
Sep 10, 2026
| truns = | ||
| for _segment <- 1..2 do | ||
| assert_sink_buffer(pipeline, :sink, buffer) | ||
| assert_composition_offset_version(buffer.payload) |
Contributor
There was a problem hiding this comment.
Hmm, do I get it right that we expect first segment to use version 1 box and the second segment to use version 0?
If so, I would prefer to explicitly assert on the desired box version that have assert_composition_offset_version determine the version itself, using the same logic that is used in the lib
Elixir 1.19+ warns when a size(...) in a match references an outer variable without ^, and CI runs with --warnings-as-errors.
varsill
force-pushed
the
fix/h265-b-frame-timestamps
branch
from
September 24, 2026 13:05
8c9e4a1 to
f03f856
Compare
Contributor
|
Thank you very much for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the B-frames are present in the stream the muxer just crashing. That's because the B-frames could come "late" in point of view of the muxer (ctts version 0 is using uint and can't express negative values). Added support for ctts version 1.