AV1 muxer by maslowalex · Pull Request #125 · membraneframework/membrane_mp4_plugin

maslowalex · 2026-02-04T13:29:05Z

No description provided.

mat-hek

Please refactor as we spoke on DC https://discord.com/channels/464786597288738816/1446470754995671092/1473283552262230213

Also, make it depend on https://github.com/membraneframework/membrane_av1_format

Noarkhh

Hi, thank you for the contribution! Sorry this took so long, but I was during the development of membrane_av1_plugin and wanted to finish working on the encoder and decoder there, so that the API is somewhat stable.

During said development there were changes to Membrane.AV1 format and I added suggestions conforming to the new version.

Also please add tests in test/membrane_mp4/demuxer/isom/integration_test.exs.

Noarkhh · 2026-07-02T07:18:57Z

+      profile: format.profile || 0,
+      level_idx: level_string_to_idx(format.level) || 8,
+      tier: format.tier || 0,


In the last release of membrane_av1_format, these three fields are now all atoms. They can be converted to their respective seq_ values with utility functions from Membrane.AV1 module:
profile_to_seq_profile/1, level_to_seq_level_idx/1 and tier_to_seq_tier/1

Noarkhh · 2026-07-02T07:19:51Z

+  # Convert AV1 level string to level index
+  defp level_string_to_idx(nil), do: nil
+  defp level_string_to_idx("2.0"), do: 0
+  defp level_string_to_idx("2.1"), do: 1
+  defp level_string_to_idx("3.0"), do: 4
+  defp level_string_to_idx("3.1"), do: 5
+  defp level_string_to_idx("4.0"), do: 8
+  defp level_string_to_idx("4.1"), do: 9
+  defp level_string_to_idx("5.0"), do: 12
+  defp level_string_to_idx("5.1"), do: 13
+  defp level_string_to_idx("5.2"), do: 14
+  defp level_string_to_idx("5.3"), do: 15
+  defp level_string_to_idx("6.0"), do: 16
+  defp level_string_to_idx("6.1"), do: 17
+  defp level_string_to_idx("6.2"), do: 18
+  defp level_string_to_idx("6.3"), do: 19
+  defp level_string_to_idx(_), do: nil
+


These will no longer be necessary

Noarkhh · 2026-07-02T07:20:43Z

        },
-        %Membrane.Opus{self_delimiting?: false}
+        %Membrane.Opus{self_delimiting?: false},
+        %Membrane.AV1{}


Suggested change

%Membrane.AV1{}

%Membrane.AV1{alignment: :tu}

Noarkhh · 2026-07-02T07:45:32Z

+          | {:av01,
+             %{profile: non_neg_integer(), level: String.t() | nil, tier: non_neg_integer()}}


The convention is to use raw values from the format, so I propose to do it for level as well

Suggested change

| {:av01,

%{profile: non_neg_integer(), level: String.t() | nil, tier: non_neg_integer()}}

| {:av01,

%{profile: non_neg_integer(), level: non_neg_integer(), tier: non_neg_integer()}}

This also needs to be added to Membrane.CMAF.Track.t() in membrane_cmaf_format package, if you could open a PR there that would be great

Noarkhh · 2026-07-02T07:46:10Z

+      profile: format.profile || 0,
+      level: format.level,
+      tier: format.tier || 0


Same as before, use utility functions from Membrane.AV1

Noarkhh · 2026-07-02T07:48:19Z


    # partial segments for the following 8 seconds without a keyframe
-    for _iteration <- 1..16 do
+    for _ <- 1..16 do


It was like this previously because we have credo warn when a variable is named _

Suggested change

for _ <- 1..16 do

for _iteration <- 1..16 do

Noarkhh · 2026-07-02T07:48:40Z

      {:membrane_h264_format, "~> 0.6.1"},
      {:membrane_h265_format, "~> 0.2.0"},
      {:membrane_opus_format, "~> 0.3.0"},
+      {:membrane_av1_format, "~> 0.1.0"},


Suggested change

{:membrane_av1_format, "~> 0.1.0"},

{:membrane_av1_format, "~> 0.3.0"},

…1_format dependency

Noarkhh

looks good overall, but please address these naming suggestions and add some muxer tests

Noarkhh · 2026-08-19T09:44:16Z

  alias Membrane.MP4.MovieBox.SampleTableBox
  alias Membrane.MP4.Track.SampleTable

+  @temporal_delimiter <<0x12, 0x00>>


Suggested change

@temporal_delimiter <<0x12, 0x00>>

@av1_temporal_delimiter_obu <<0x12, 0x00>>

Noarkhh · 2026-08-19T09:45:18Z

+  defp strip_temporal_delimiter(<<0x12, 0x00, rest::binary>>), do: strip_temporal_delimiter(rest)
+  defp strip_temporal_delimiter(payload), do: payload


Suggested change

defp strip_temporal_delimiter(<<0x12, 0x00, rest::binary>>), do: strip_temporal_delimiter(rest)

defp strip_temporal_delimiter(payload), do: payload

defp strip_av1_temporal_delimiter_obu(<<0x12, 0x00, rest::binary>>), do: strip_temporal_delimiter(rest)

defp strip_av1_temporal_delimiter_obu(payload), do: payload

maslowalex requested a review from mat-hek as a code owner February 4, 2026 13:29

mat-hek added this to Smackore Feb 5, 2026

mat-hek moved this to In Review in Smackore Feb 5, 2026

Noarkhh assigned mat-hek Feb 5, 2026

mat-hek requested changes Mar 24, 2026

View reviewed changes

maslowalex requested a review from mat-hek March 26, 2026 13:20

Noarkhh assigned Noarkhh and unassigned mat-hek May 7, 2026

mat-hek requested review from Noarkhh and removed request for mat-hek May 14, 2026 11:00

maslowalex force-pushed the av1-muxer branch 2 times, most recently from 8ce056a to e02a7c3 Compare June 29, 2026 10:01

Noarkhh requested changes Jul 2, 2026

View reviewed changes

maslowalex force-pushed the av1-muxer branch 2 times, most recently from 73b2af4 to 9a96a0d Compare August 11, 2026 11:03

maslowalex added 5 commits August 11, 2026 14:35

Support AV1 in Muxer

93f4309

added membrane_av1_format library

c3a29aa

removed redundant deps

0f6f9fe

fix: reverted unrelated changes, refactored code, use the membrane_av…

54d6e3d

…1_format dependency

fix: addressed the PR comments

bfce5a4

maslowalex force-pushed the av1-muxer branch from 9a96a0d to bfce5a4 Compare August 11, 2026 11:47

maslowalex requested review from Noarkhh and mat-hek August 11, 2026 11:58

chore: bump membrane_av1_format to 0.3.1

35a0e8e

Noarkhh requested changes Aug 19, 2026

View reviewed changes

mat-hek removed their request for review August 21, 2026 14:57

maslowalex added 2 commits September 2, 2026 10:48

chore: addressed naming suggestions and fixed credo

0e1c23e

test: added muxer test

883273f

maslowalex requested a review from Noarkhh September 2, 2026 08:08

maslowalex requested a review from mat-hek September 11, 2026 08:55

Satisfy credo and compiler

f9b5e70

Noarkhh removed the request for review from mat-hek September 30, 2026 20:24

Noarkhh approved these changes Sep 30, 2026

View reviewed changes

Noarkhh merged commit 0bf4ec8 into membraneframework:master Sep 30, 2026
4 checks passed

		\| {:av01,
		%{profile: non_neg_integer(), level: String.t() \| nil, tier: non_neg_integer()}}

	{:membrane_av1_format, "~> 0.1.0"},
	{:membrane_av1_format, "~> 0.3.0"},

	@temporal_delimiter <<0x12, 0x00>>
	@av1_temporal_delimiter_obu <<0x12, 0x00>>

		defp strip_temporal_delimiter(<<0x12, 0x00, rest::binary>>), do: strip_temporal_delimiter(rest)
		defp strip_temporal_delimiter(payload), do: payload

Conversation

maslowalex commented Feb 4, 2026

Uh oh!

mat-hek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Noarkhh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Noarkhh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mat-hek left a comment •

edited

Loading