Repository navigation
Add subscription parameters to MoQ.Source, enable integration tests on CI - #8
Conversation
kidq330
changed the title
| @track "video" | ||
| @audio_track "audio" | ||
|
|
||
| @subscription %ExMoQ.Subscription{group_start: 0, latency_ns: Membrane.Time.seconds(5)} |
There was a problem hiding this comment.
You shouldn't assume that Membrane.Time is in fact integer meaning number of nanoseconds. It is a part of a private API and it may change in the future
| get_child(:source) | ||
| |> via_out(Pad.ref(:output, generation), options: [track: name]) | ||
| |> via_out(Pad.ref(:output, generation), | ||
| options: [track: name, subscription: @subscription] |
There was a problem hiding this comment.
Does it make sense, to require specifying both track name and subscription? Maybe sbd who has some expertise in MoQ could look at it too
There was a problem hiding this comment.
I don't think it's too important, the struct is just a bundle of parameters, we may just as well put :track inside it. It would be closer to moq-lite's structure of SUBSCRIBE, see https://datatracker.ietf.org/doc/draft-lcurley-moq-lite/ §7.7
for comparison, IETF MoQ splits the track name and parameters: https://www.ietf.org/archive/id/draft-ietf-moq-transport-21.html#section-9.6
It makes sense for me to have the current shape with the track name as the "most important" parameter, but it could just as well be a required value for the struct, your call
2 participants
No description provided.