Repository navigation
Extract ex_moq - #7
Merged
Merged
Conversation
kidq330
marked this pull request as ready for review
August 26, 2026 15:33
kidq330
force-pushed
the
kidq330/extract_ex_moq
branch
from
August 26, 2026 15:35
fa962f8 to
375add5
Compare
varsill
requested changes
Sep 3, 2026
varsill
left a comment
varsill
left a comment
Contributor
There was a problem hiding this comment.
[NIT] Remember to remove Rust's target/ from .gitignore ;)
| {:membrane_aac_format, "~> 0.8.0"}, | ||
| {:membrane_opus_format, "~> 0.3.0"}, | ||
| # TODO: change to released version once it's public | ||
| {:ex_moq, github: "membraneframework/ex_moq", branch: "kidq330/group_loss_fixed"}, |
Contributor
There was a problem hiding this comment.
Hmm shouldn't it point now to kidq330/initial?
Member
Author
There was a problem hiding this comment.
yup that's a leftover from debugging CI
| {:ex_moq, github: "membraneframework/ex_moq", branch: "kidq330/group_loss_fixed"}, | ||
| {:muontrap, ">= 0.0.0", only: :test}, | ||
| {:membrane_aac_plugin, "~> 0.19", only: :test}, | ||
| {:muontrap, "~> 1.8", only: :test}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.