fix(cli): support FOVs with differing ZYX shapes - #575
Open
srivarra wants to merge 2 commits into
Open
Conversation
A transfer function is only valid for the ZYX shape it was computed from, but `reconstruct` computed one from the first position and applied it to every position, silently corrupting mixed-shape HCS plates. Group positions by ZYX shape, compute one transfer function per shape. - `apply-inv-tf` takes a single transfer function, so mixed shapes fail fast instead of writing wrong output. - `create_empty_plate` allocates one shape and scale per call, so output metadata is derived per position.
Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
srivarra
marked this pull request as ready for review
August 8, 2026 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run a pass through the HCS store, and group positions by ZYX shape, then compute one transfer function per unique ZYX shape.
apply-inv-tftakes a single transfer function, so mixed shapes fail fast instead of writing wrong output.create_empty_plateallocates one shape and scale per call, so output metadata is derived per position.