Skip to content

test(audit): accept records that land in the old inode before SIGHUP reopen - #666

Merged
fastrevmd-lab merged 1 commit into
mainfrom
test/sighup-audit-rotation-flake
Nov 22, 2026
Merged

fastrevmd-lab merged 1 commit into
mainfrom
test/sighup-audit-rotation-flake

Conversation

@fastrevmd-lab

Copy link
Copy Markdown
Member

sighup_reopens_audit_log_after_rename asserted the rotated-away file equals the pre-rename contents exactly. Records emitted after the rename but before the SIGHUP reopen completes correctly land in the old inode, so the equality was racy (failed CI on #620).

Now asserts the rotated file starts with everything written before the rename: still proves nothing is lost, while allowing extra pre-reopen records. The new-file assertions are unchanged.

Branch from 2026-11-04, rebased onto main.

🤖 Generated with Claude Code

…reopen

sighup_reopens_audit_log_after_rename polls audit records right after
SIGHUP until one appears at the original path. Records emitted before the
reopen completes correctly go to the renamed (old) inode, so asserting the
rotated file equals the pre-rename contents exactly was racy and failed
CI on #620. Assert the rotated file still starts with everything written
before the rename instead: nothing lost, extra pre-reopen records allowed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fastrevmd-lab
fastrevmd-lab merged commit 2fea3e2 into main Nov 22, 2026
12 checks passed
@fastrevmd-lab
fastrevmd-lab deleted the test/sighup-audit-rotation-flake branch November 22, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant