Repository navigation
test(audit): accept records that land in the old inode before SIGHUP reopen - #666
Merged
Merged
Conversation
…reopen sighup_reopens_audit_log_after_rename polls audit records right after SIGHUP until one appears at the original path. Records emitted before the reopen completes correctly go to the renamed (old) inode, so asserting the rotated file equals the pre-rename contents exactly was racy and failed CI on #620. Assert the rotated file still starts with everything written before the rename instead: nothing lost, extra pre-reopen records allowed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sighup_reopens_audit_log_after_renameasserted the rotated-away file equals the pre-rename contents exactly. Records emitted after the rename but before the SIGHUP reopen completes correctly land in the old inode, so the equality was racy (failed CI on #620).Now asserts the rotated file starts with everything written before the rename: still proves nothing is lost, while allowing extra pre-reopen records. The new-file assertions are unchanged.
Branch from 2026-11-04, rebased onto main.
🤖 Generated with Claude Code