Skip to content

fix(srx-ips): show the security-policy IDP binding (0.1.5) - #117

Merged
fastrevmd-lab merged 1 commit into
mainfrom
fix/srx-ips-binding-example
Nov 15, 2026
Merged

fastrevmd-lab merged 1 commit into
mainfrom
fix/srx-ips-binding-example

Conversation

@fastrevmd-lab

@fastrevmd-lab fastrevmd-lab commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Summary

#115 is merged; this branch is rebased onto main and is now one commit (srx-ips 0.1.4 → 0.1.5).

reposbot's nightly srx-ips task failed with application or application-set must be defined: the model copied the IDP-rule keyword match application default into the security policy, and the skill showed no binding example. The skill now shows:

  • the global-policy binding: then permit application-services idp-policy <idp-policy> with match application any;
  • that match application default belongs only inside an IDP rule, and the error it gives in a security policy;
  • that a device without the IDP signature database fails commit check with Please install the Signature Database. That's a content gap (srx-license-signature-maintenance), not a syntax error.

Type of change

  • New skill
  • Update to an existing skill (skills/<name>/)
  • Cross-skill / shared infrastructure (installer, scripts, shared schema, CI, docs)

Verification

just lint && just test   # exit 0

commit_check_config on lab vSRX vsrx-ci, Junos 26.2R1.7, nothing committed:

  • global policy with match application default only → application or application-set must be defined.
  • reposbot's IDP policy + global policy with match application any and the binding → parses (diff shows application-services { idp-policy sbot-idp; }), then fails Please install the Signature Database.

Checklist

  • just lint passes
  • just test passes
  • No skill added or renamed
  • No parsing-* schema touched
  • No scripts or executables added under skills/
  • Examples are synthetic
  • No device-changing step altered
  • Vendor syntax backed by commit-check output
  • No new telemetry or outbound calls

Anything you're unsure about

The binding has not passed a full commit check here because vsrx-ci has no IDP signature database. Only the parse is verified.

🤖 Generated with Claude Code

reposbot's srx-ips task copied the IDP-only `match application default`
into the security policy. The skill now shows the binding line and the two
commit-check errors seen on vsrx-ci (26.2R1.7): the misplaced application
match, and a missing IDP signature database.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fastrevmd-lab
fastrevmd-lab force-pushed the fix/srx-ips-binding-example branch from d2aa5bf to c70b7e5 Compare November 15, 2026 19:39
@fastrevmd-lab
fastrevmd-lab merged commit 33268e1 into main Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant