Repository navigation
fix(srx-ips): show the security-policy IDP binding (0.1.5) - #117
Merged
Merged
Conversation
reposbot's srx-ips task copied the IDP-only `match application default` into the security policy. The skill now shows the binding line and the two commit-check errors seen on vsrx-ci (26.2R1.7): the misplaced application match, and a missing IDP signature database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fastrevmd-lab
force-pushed
the
fix/srx-ips-binding-example
branch
from
November 15, 2026 19:39
d2aa5bf to
c70b7e5
Compare
10 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#115 is merged; this branch is rebased onto main and is now one commit (srx-ips 0.1.4 → 0.1.5).
reposbot's nightly srx-ips task failed with
application or application-set must be defined: the model copied the IDP-rule keywordmatch application defaultinto the security policy, and the skill showed no binding example. The skill now shows:then permit application-services idp-policy <idp-policy>withmatch application any;match application defaultbelongs only inside an IDP rule, and the error it gives in a security policy;commit checkwithPlease install the Signature Database. That's a content gap (srx-license-signature-maintenance), not a syntax error.Type of change
skills/<name>/)Verification
commit_check_configon lab vSRXvsrx-ci, Junos 26.2R1.7, nothing committed:match application defaultonly →application or application-set must be defined.match application anyand the binding → parses (diff showsapplication-services { idp-policy sbot-idp; }), then failsPlease install the Signature Database.Checklist
just lintpassesjust testpassesparsing-*schema touchedskills/Anything you're unsure about
The binding has not passed a full commit check here because vsrx-ci has no IDP signature database. Only the parse is verified.
🤖 Generated with Claude Code