Skip to content

netlink: handle capped extended acknowledgements - #322

Merged
nickgarlis merged 1 commit into
mdlayher:mainfrom
nickgarlis:handle-capped-ext-acks
Oct 11, 2026
Merged

nickgarlis merged 1 commit into
mdlayher:mainfrom
nickgarlis:handle-capped-ext-acks

Conversation

@nickgarlis

Copy link
Copy Markdown
Collaborator

With NETLINK_CAP_ACK, the kernel echoes only the request's nlmsghdr but leaves its length unchanged, so the TLVs were looked for past where they are. Skip just the header when NLM_F_CAPPED is set.

@nickgarlis
nickgarlis force-pushed the handle-capped-ext-acks branch from 1e7b8ae to 4d2c0c3 Compare October 10, 2026 15:27
@nickgarlis
nickgarlis requested a review from mdlayher October 10, 2026 15:38
With NETLINK_CAP_ACK, the kernel echoes only the request's nlmsghdr but
leaves its length unchanged, so the TLVs were looked for past where they
are. Skip just the header when NLM_F_CAPPED is set.
@nickgarlis
nickgarlis force-pushed the handle-capped-ext-acks branch from 4d2c0c3 to d14e78b Compare October 10, 2026 17:18

@mdlayher mdlayher left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, LGTM thanks.

@nickgarlis
nickgarlis merged commit 3d7970b into mdlayher:main Oct 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants