netlink: extract marshalMessages for independent testing and benchmarking - #310
Merged
Merged
Conversation
…king SendMessages previously inlined the logic to serialize a slice of Messages into a single buffer. Extract this into a separate marshalMessages function with its own test and benchmark. This is a first step toward investigating whether there are any benefits to optimizing the serialization path in SendMessages, as discussed in mdlayher#254.
Collaborator
|
The down side here is that we're going to make a copy of |
Collaborator
Author
You mean by passing down the slice of messages into |
SuperQ
approved these changes
Jul 19, 2026
SuperQ
left a comment
SuperQ
left a comment
Collaborator
There was a problem hiding this comment.
I don't remember if the Go compiler is smart enough to optimize away the copy. Structurally this seems fine.
nickgarlis
added a commit
to nickgarlis/netlink
that referenced
this pull request
Sep 6, 2026
…king (mdlayher#310) SendMessages previously inlined the logic to serialize a slice of Messages into a single buffer. Extract this into a separate marshalMessages function with its own test and benchmark. This is a first step toward investigating whether there are any benefits to optimizing the serialization path in SendMessages, as discussed in mdlayher#254.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendMessages previously inlined the logic to serialize a slice of Messages into a single buffer. Extract this into a separate marshalMessages function with its own test and benchmark.
This is a first step toward investigating whether there are any benefits to optimizing the serialization path in SendMessages, as discussed in #254.