deduplicating Elastic logic, reorganising definitions, improving exce…#54
Quality Gate failed
Failed conditions
See analysis details on SonarQube Cloud
Annotations
Check warning on line 116 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
The result of "std::move" should not be passed as a const reference.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHI&open=AZ8I6taMHYiRC2s7ZYHI&pullRequest=54
Check failure on line 35 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Customize this struct's copy constructor to participate in resource management. Customize or delete its copy assignment operator. Also consider whether move operations should be customized.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHC&open=AZ8I6taMHYiRC2s7ZYHC&pullRequest=54
Check failure on line 98 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture all local variables required in this lambda.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHG&open=AZ8I6taMHYiRC2s7ZYHG&pullRequest=54
Check warning on line 185 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Use std::format instead of concatenating pieces manually.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHM&open=AZ8I6taMHYiRC2s7ZYHM&pullRequest=54
Check warning on line 63 in source/ingest/udpReceiver.cpp
sonarqubecloud / SonarCloud Code Analysis
Use std::format instead of concatenating pieces manually.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6tYHHYiRC2s7ZYHA&open=AZ8I6tYHHYiRC2s7ZYHA&pullRequest=54
Check warning on line 72 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Using HTTP is insecure. Use HTTPS instead.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHE&open=AZ8I6taMHYiRC2s7ZYHE&pullRequest=54
Check warning on line 83 in source/shared/redis/consumer/drainRuns.cpp
sonarqubecloud / SonarCloud Code Analysis
Declare this variable in a separate statement.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uW-NAV-IEzsl2cD&open=AZ796uW-NAV-IEzsl2cD&pullRequest=54
Check warning on line 38 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Declare this variable in a separate statement.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHB&open=AZ8I6taMHYiRC2s7ZYHB&pullRequest=54
Check failure on line 80 in source/shared/redis/consumer/drainRuns.cpp
sonarqubecloud / SonarCloud Code Analysis
Customize this struct's copy constructor to participate in resource management (the copy constructor is implicitly created).
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uW-NAV-IEzsl2cE&open=AZ796uW-NAV-IEzsl2cE&pullRequest=54
Check warning on line 136 in source/shared/redis/consumer/drainRuns.cpp
sonarqubecloud / SonarCloud Code Analysis
"catch" a specific exception type.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uW-NAV-IEzsl2cC&open=AZ796uW-NAV-IEzsl2cC&pullRequest=54
Check warning on line 105 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Fill this compound statement, remove it, or add a nested comment explaining why it is empty.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHH&open=AZ8I6taMHYiRC2s7ZYHH&pullRequest=54
Check failure on line 98 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture the required scope variables.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHF&open=AZ8I6taMHYiRC2s7ZYHF&pullRequest=54
Check failure on line 26 in source/shared/reporting/elasticPublisher.cpp
sonarqubecloud / SonarCloud Code Analysis
Customize this struct's copy constructor to participate in resource management. Customize or delete its copy assignment operator. Also consider whether move operations should be customized.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uZcNAV-IEzsl2cG&open=AZ796uZcNAV-IEzsl2cG&pullRequest=54
Check warning on line 54 in source/shared/reporting/elasticPublisher.cpp
sonarqubecloud / SonarCloud Code Analysis
Use "std::string" instead of a C-style char array.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uZcNAV-IEzsl2cI&open=AZ796uZcNAV-IEzsl2cI&pullRequest=54
Check failure on line 46 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace this use of "void *" with a more meaningful type.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHN&open=AZ8I6taMHYiRC2s7ZYHN&pullRequest=54
Check warning on line 29 in source/shared/reporting/elasticPublisher.cpp
sonarqubecloud / SonarCloud Code Analysis
Declare this variable in a separate statement.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uZcNAV-IEzsl2cF&open=AZ796uZcNAV-IEzsl2cF&pullRequest=54
Check warning on line 142 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Use the init-statement to declare "rc" inside the if statement.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHJ&open=AZ8I6taMHYiRC2s7ZYHJ&pullRequest=54
Check warning on line 151 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Use std::format instead of concatenating pieces manually.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHL&open=AZ8I6taMHYiRC2s7ZYHL&pullRequest=54
Check warning on line 131 in source/shared/redis/consumer/drainRuns.cpp
sonarqubecloud / SonarCloud Code Analysis
Catch a more specific exception instead of a generic one.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uW-NAV-IEzsl2cB&open=AZ796uW-NAV-IEzsl2cB&pullRequest=54
Check failure on line 77 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Use stronger SSL and TLS versions
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHO&open=AZ8I6taMHYiRC2s7ZYHO&pullRequest=54
Check warning on line 55 in source/shared/reporting/elasticPublisher.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace this use of "strftime" with equivalent code using "std::chrono".
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uZcNAV-IEzsl2cH&open=AZ796uZcNAV-IEzsl2cH&pullRequest=54
Check warning on line 119 in source/shared/reporting/elasticPublisher.cpp
sonarqubecloud / SonarCloud Code Analysis
Use std::format instead of concatenating pieces manually.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uZcNAV-IEzsl2cJ&open=AZ796uZcNAV-IEzsl2cJ&pullRequest=54
Check failure on line 41 in source/shared/reporting/elasticPublisher.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace this use of "void *" with a more meaningful type.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ796uZcNAV-IEzsl2cK&open=AZ796uZcNAV-IEzsl2cK&pullRequest=54
Check warning on line 72 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Use std::format instead of concatenating pieces manually.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHD&open=AZ8I6taMHYiRC2s7ZYHD&pullRequest=54
Check warning on line 127 in source/ingest/questdbIngestClient.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace this const reference to "std::string" by a "std::string_view".
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ8I6taMHYiRC2s7ZYHK&open=AZ8I6taMHYiRC2s7ZYHK&pullRequest=54