Refactoring to swap from decimals to ints, to .cppm modules and remov…#50
Quality Gate failed
Failed conditions
Annotations
Check warning on line 35 in source/shared/utilities/decimalJson.hpp
sonarqubecloud / SonarCloud Code Analysis
Use "std::string" instead of a C-style char array.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5COEjwYLwgbYaQ_&open=AZ7mY5COEjwYLwgbYaQ_&pullRequest=50
Check warning on line 36 in source/shared/redis/redisConnection.cpp
sonarqubecloud / SonarCloud Code Analysis
'async_run<boost::asio::consign_t<boost::asio::detached_t, std::shared_ptr<boost::redis::connection>>>' is deprecated: The async_run overload taking a logger argument is deprecated. Please pass the logger to the connection's constructor, instead, and use the other async_run overloads.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5DEEjwYLwgbYaRD&open=AZ7mY5DEEjwYLwgbYaRD&pullRequest=50
Check warning on line 19 in source/shared/tradingDefinitions/configuration.hpp
sonarqubecloud / SonarCloud Code Analysis
Remove the misleading "/*" characters.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5DYEjwYLwgbYaRE&open=AZ7mY5DYEjwYLwgbYaRE&pullRequest=50
Check warning on line 106 in source/shared/utilities/threadPool.hpp
sonarqubecloud / SonarCloud Code Analysis
Replace with the simpler "std::condition_variable".
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5CFEjwYLwgbYaQ-&open=AZ7mY5CFEjwYLwgbYaQ-&pullRequest=50
Check warning on line 27 in source/shared/utilities/backtestLog.hpp
sonarqubecloud / SonarCloud Code Analysis
Avoid explicitly specifying the template arguments by relying on the class template argument deduction.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mhiWqahmNBK0SDxgi&open=AZ7mhiWqahmNBK0SDxgi&pullRequest=50
Check warning on line 38 in source/shared/utilities/decimalJson.hpp
sonarqubecloud / SonarCloud Code Analysis
Define and throw a dedicated exception instead of using a generic one.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5COEjwYLwgbYaRA&open=AZ7mY5COEjwYLwgbYaRA&pullRequest=50
Check warning on line 87 in source/shared/utilities/threadPool.hpp
sonarqubecloud / SonarCloud Code Analysis
"catch" a specific exception type.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5CFEjwYLwgbYaQ9&open=AZ7mY5CFEjwYLwgbYaQ9&pullRequest=50
Check warning on line 47 in source/shared/utilities/decimalJson.hpp
sonarqubecloud / SonarCloud Code Analysis
Define and throw a dedicated exception instead of using a generic one.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5COEjwYLwgbYaRB&open=AZ7mY5COEjwYLwgbYaRB&pullRequest=50
Check warning on line 36 in source/shared/redis/redisConnection.cpp
sonarqubecloud / SonarCloud Code Analysis
'async_run' is deprecated: The async_run overload taking a logger argument is deprecated. Please pass the logger to the connection's constructor, instead, and use the other async_run overloads.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mY5DEEjwYLwgbYaRC&open=AZ7mY5DEEjwYLwgbYaRC&pullRequest=50
Check failure on line 38 in source/shared/utilities/backtestLog.hpp
sonarqubecloud / SonarCloud Code Analysis
Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mhiWqahmNBK0SDxgk&open=AZ7mhiWqahmNBK0SDxgk&pullRequest=50
Check failure on line 34 in source/shared/utilities/backtestLog.hpp
sonarqubecloud / SonarCloud Code Analysis
Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.
See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ7mhiWqahmNBK0SDxgj&open=AZ7mhiWqahmNBK0SDxgj&pullRequest=50