mission planning editing views toggle for geofense, mission items#14544
mission planning editing views toggle for geofense, mission items#14544n-sleeman wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Plan View editors to request activation of the appropriate editing layer on user interaction, and adjusts control-status handling in Vehicle.
Changes:
- Add
requestEditingLayersignals to GeoFence and Rally editors and wire them inPlanTreeViewto switch the active editing layer. - Ensure Mission selection also requests the Mission editing layer for interactive map tools.
- Update vehicle control-status handling to use
sysid_in_controlinstead ofgcs_main.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Vehicle/Vehicle.cc | Switches control-status comparison/assignment to sysid_in_control. |
| src/PlanView/RallyPointItemEditor.qml | Adds requestEditingLayer signal and emits it on selection. |
| src/PlanView/PlanTreeView.qml | Connects editor signals/clicks to request the corresponding active editing layer. |
| src/PlanView/GeoFenceEditor.qml | Adds requestEditingLayer signal and emits it on user actions; fixes a visibility condition for circle UI. |
| if (_gcsMain != controlStatus.sysid_in_control) { | ||
| _gcsMain = controlStatus.sysid_in_control; | ||
| updateControlStatusSignals = true; | ||
| } |
| if (delegateRoot.nodeType === "fenceEditor" && item) { | ||
| // Interacting with the GeoFence editor makes the fence the active | ||
| // editing layer so its map visuals become interactive. | ||
| item.requestEditingLayer.connect(function() { | ||
| root.editingLayerChangeRequested(root._layerFence) | ||
| }) | ||
| } | ||
| if (delegateRoot.nodeType === "rallyItem" && item) { | ||
| // Selecting a rally point makes Rally the active editing layer so its | ||
| // map visuals become interactive. | ||
| item.requestEditingLayer.connect(function() { | ||
| root.editingLayerChangeRequested(root._layerRally) | ||
| }) | ||
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14544 +/- ##
==========================================
+ Coverage 25.47% 30.20% +4.73%
==========================================
Files 769 772 +3
Lines 65912 66943 +1031
Branches 30495 31090 +595
==========================================
+ Hits 16788 20218 +3430
+ Misses 37285 32997 -4288
- Partials 11839 13728 +1889
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 75 failed, 7 skipped. Test Resultslinux-coverage: 100 passed, 0 skipped Code CoverageCoverage: 65.1% No baseline available for comparison Artifact Sizes
Updated: 2026-06-16 21:58:02 UTC • Commit: 9066767 • Triggered by: Android |
Description
bug: Geofence only editable when you don't expand mission items first, this fix allows toggling edit layers of mission items, geofences and rallypoints.
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).