Skip to content

Remove Verify - #398

Merged
mauroservienti merged 2 commits into
masterfrom
remove-verify-approvaltests
Oct 6, 2026
Merged

mauroservienti merged 2 commits into
masterfrom
remove-verify-approvaltests

Conversation

@mauroservienti

Copy link
Copy Markdown
Owner

Removes Verify and replaces it with a small Approver.Verify(string) helper in the test project(s).

Why: Verify 33 introduced a SponsorCheck licensing gate that fails the build (SC021), and ApprovalTests is no longer maintained. The tests only compare a string (public API from PublicApiGenerator) against an approved file, which doesn't need a third-party library.

How the helper works:

  • Uses [CallerFilePath]/[CallerMemberName] to locate {TestFile}.{TestMethod}.approved.txt next to the test source (same convention as before).
  • Compares with line endings normalized and trailing whitespace trimmed.
  • On mismatch, writes {TestFile}.{TestMethod}.received.txt (already git-ignored) and fails with the paths of both files. To accept a change, replace the approved file with the received one.

The seven snapshots were renamed from .verified.txt to .approved.txt; content is unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AixzAbo1zbJgxpHo7vyoSc

mauroservienti and others added 2 commits October 6, 2026 10:33
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AixzAbo1zbJgxpHo7vyoSc
@mauroservienti
mauroservienti merged commit b4731a4 into master Oct 6, 2026
4 of 5 checks passed
@mauroservienti
mauroservienti deleted the remove-verify-approvaltests branch October 6, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant